Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/tools/quic/quic_simple_server_stream_test.cc

Issue 2875333002: Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_stream.cc ('k') | net/tools/quic/quic_spdy_client_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_stream_test.cc
diff --git a/net/tools/quic/quic_simple_server_stream_test.cc b/net/tools/quic/quic_simple_server_stream_test.cc
index 685f17590acd6973f968f77e7eaf401bc4350fbf..93b06cf5280d6d6ff7244053aedb8382fb9dfb09 100644
--- a/net/tools/quic/quic_simple_server_stream_test.cc
+++ b/net/tools/quic/quic_simple_server_stream_test.cc
@@ -326,9 +326,6 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithIllegalResponseStatus) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_TRUE(stream_->reading_stopped());
- }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -359,9 +356,6 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithIllegalResponseStatus2) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_TRUE(stream_->reading_stopped());
- }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -417,9 +411,6 @@ TEST_P(QuicSimpleServerStreamTest, SendResponseWithValidHeaders) {
QuicSimpleServerStreamPeer::SendResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_TRUE(stream_->reading_stopped());
- }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -524,9 +515,6 @@ TEST_P(QuicSimpleServerStreamTest, TestSendErrorResponse) {
QuicSimpleServerStreamPeer::SendErrorResponse(stream_);
EXPECT_FALSE(QuicStreamPeer::read_side_closed(stream_));
- if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_TRUE(stream_->reading_stopped());
- }
EXPECT_TRUE(stream_->write_side_closed());
}
@@ -585,22 +573,6 @@ TEST_P(QuicSimpleServerStreamTest, ValidMultipleContentLength) {
EXPECT_FALSE(stream_->write_side_closed());
}
-TEST_P(QuicSimpleServerStreamTest, SendQuicRstStreamNoErrorWithEarlyResponse) {
- if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- return;
- }
- InSequence s;
- EXPECT_CALL(session_, WriteHeadersMock(stream_->id(), _, false, _, _));
- EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
- .Times(1)
- .WillOnce(Return(QuicConsumedData(3, true)));
- EXPECT_CALL(session_, SendRstStream(_, QUIC_STREAM_NO_ERROR, _)).Times(1);
- EXPECT_FALSE(stream_->fin_received());
- QuicSimpleServerStreamPeer::SendErrorResponse(stream_);
- EXPECT_TRUE(stream_->reading_stopped());
- EXPECT_TRUE(stream_->write_side_closed());
-}
-
TEST_P(QuicSimpleServerStreamTest,
DoNotSendQuicRstStreamNoErrorWithRstReceived) {
InSequence s;
« no previous file with comments | « net/tools/quic/quic_simple_server_stream.cc ('k') | net/tools/quic/quic_spdy_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698