Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: net/quic/core/quic_version_manager_test.cc

Issue 2875333002: Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_version_manager_test.cc
diff --git a/net/quic/core/quic_version_manager_test.cc b/net/quic/core/quic_version_manager_test.cc
index 89f7222e7aaf826eaaffae509ea6b4ba94bcc13e..6a3f9c13b19a0984cb973dad883d55e30f580245 100644
--- a/net/quic/core/quic_version_manager_test.cc
+++ b/net/quic/core/quic_version_manager_test.cc
@@ -16,6 +16,7 @@ namespace {
class QuicVersionManagerTest : public QuicTest {};
TEST_F(QuicVersionManagerTest, QuicVersionManager) {
+ SetQuicFlag(&FLAGS_quic_enable_version_40, false);
FLAGS_quic_reloadable_flag_quic_enable_version_39 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_38 = false;
QuicVersionManager manager(AllSupportedVersions());
@@ -41,14 +42,24 @@ TEST_F(QuicVersionManagerTest, QuicVersionManager) {
EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[3]);
EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[4]);
+ SetQuicFlag(&FLAGS_quic_enable_version_40, true);
+ ASSERT_EQ(6u, manager.GetSupportedVersions().size());
+ EXPECT_EQ(QUIC_VERSION_40, manager.GetSupportedVersions()[0]);
+ EXPECT_EQ(QUIC_VERSION_39, manager.GetSupportedVersions()[1]);
+ EXPECT_EQ(QUIC_VERSION_38, manager.GetSupportedVersions()[2]);
+ EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[3]);
+ EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[4]);
+ EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[5]);
+
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- ASSERT_EQ(5u, manager.GetSupportedVersions().size());
- EXPECT_EQ(QUIC_VERSION_39, manager.GetSupportedVersions()[0]);
- EXPECT_EQ(QUIC_VERSION_38, manager.GetSupportedVersions()[1]);
- EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[2]);
- EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[3]);
- EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[4]);
+ ASSERT_EQ(6u, manager.GetSupportedVersions().size());
+ EXPECT_EQ(QUIC_VERSION_40, manager.GetSupportedVersions()[0]);
+ EXPECT_EQ(QUIC_VERSION_39, manager.GetSupportedVersions()[1]);
+ EXPECT_EQ(QUIC_VERSION_38, manager.GetSupportedVersions()[2]);
+ EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[3]);
+ EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[4]);
+ EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[5]);
}
} // namespace
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698