Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: net/tools/quic/quic_spdy_client_stream_test.cc

Issue 2875333002: Landing Recent QUIC changes until Mon May 8 21:42:46 2017 +0000 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.cc ('k') | net/tools/quic/test_tools/quic_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_client_stream_test.cc
diff --git a/net/tools/quic/quic_spdy_client_stream_test.cc b/net/tools/quic/quic_spdy_client_stream_test.cc
index 16e4fdfc676010a05dd1e1ffd31b230343e4912a..bd78c14559cc1cf589f07a812f553d390cac9f4d 100644
--- a/net/tools/quic/quic_spdy_client_stream_test.cc
+++ b/net/tools/quic/quic_spdy_client_stream_test.cc
@@ -154,19 +154,6 @@ TEST_F(QuicSpdyClientStreamTest, DISABLED_TestFramingExtraData) {
EXPECT_NE(QUIC_STREAM_NO_ERROR, stream_->stream_error());
}
-TEST_F(QuicSpdyClientStreamTest, TestNoBidirectionalStreaming) {
- if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- return;
- }
- QuicStreamFrame frame(
- QuicSpdySessionPeer::GetNthClientInitiatedStreamId(session_, 0), false, 3,
- QuicStringPiece("asd"));
-
- EXPECT_FALSE(stream_->write_side_closed());
- stream_->OnStreamFrame(frame);
- EXPECT_TRUE(stream_->write_side_closed());
-}
-
TEST_F(QuicSpdyClientStreamTest, ReceivingTrailers) {
// Test that receiving trailing headers, containing a final offset, results in
// the stream being closed at that byte offset.
@@ -188,14 +175,9 @@ TEST_F(QuicSpdyClientStreamTest, ReceivingTrailers) {
// Now send the body, which should close the stream as the FIN has been
// received, as well as all data.
- if (!FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_CALL(session_, CloseStream(stream_->id()));
- }
stream_->OnStreamFrame(
QuicStreamFrame(stream_->id(), /*fin=*/false, /*offset=*/0, body_));
- if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- EXPECT_TRUE(stream_->reading_stopped());
- }
+ EXPECT_TRUE(stream_->reading_stopped());
}
} // namespace
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.cc ('k') | net/tools/quic/test_tools/quic_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698