Inherit [Unforgeable] attributes between components

Inherit [Unforgeable] attributes between components

Specifically, when an interface in modules/ inherits an interface in core/
that defines an [Unforgeable] attribute, the interface in modules/ should
still have the attribute.

BUG=712070
Review-Url: https://codereview.chromium.org/2874153003
Cr-Commit-Position: refs/heads/master@{#471284}
Committed: https://chromium.googlesource.com/chromium/src/+/2a32710d5f0e31cf648120a9724d5c8b0d8e5a88

[Jens Widell, 2017-05-11 11:09:39]

jl@opera.com changed reviewers:
+ yukishiino@chromium.org

[Jens Widell, 2017-05-11 11:09:39]

PTAL

I don't understand why there was a need to not inherit these attributes between
components. Please educate me, if there is a problem with this. :-)

Also: I know we typically don't want to add more test IDL files. Only way I
could see to test this with existing files was to add an [Unforgeable] attribute
to TestInterfaceEmpty, but that seemed wrong, for obvious reasons.

[Yuki, 2017-05-11 12:11:19]

LGTM!

I don't remember exact details, but it seems that I was misunderstanding the
code-modules separation when I implemented this.  Your fix should be right.

By the way, is it easy to support the same thing for IDL operations? 
TestObject.idl has [Unforgeable] void unforgeableVoidMehod(), so it should
appear in V8TestSubObject.cpp.  Of course, it's fine to do it in a separate CL.

[haraken, 2017-05-11 12:49:36]

LGTM

[Jens Widell, 2017-05-11 12:53:29]

On 2017/05/11 at 12:11:19, yukishiino wrote:
> LGTM!
> 
> I don't remember exact details, but it seems that I was misunderstanding the
code-modules separation when I implemented this.  Your fix should be right.
> 
> By the way, is it easy to support the same thing for IDL operations? 
TestObject.idl has [Unforgeable] void unforgeableVoidMehod(), so it should
appear in V8TestSubObject.cpp.  Of course, it's fine to do it in a separate CL.

Thanks!

I will look into this for operations, but in a separate CL.

[Jens Widell, 2017-05-11 12:53:35]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2017-05-11 12:54:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 13:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 13:57:47]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jens Widell, 2017-05-12 06:19:39]

On 2017/05/11 13:57:47, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Patch updated with corrected Document-createEvent-expected.txt, which contained
expected failures that are now fixed.

[Jens Widell, 2017-05-12 06:19:50]

The CQ bit was checked by jl@opera.com

[Jens Widell, 2017-05-12 06:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2874153003/#ps20001
(title: "update Document-createEvent-expected.txt")

[commit-bot: I haz the power, 2017-05-12 06:20:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 07:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 07:14:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jens Widell, 2017-05-12 07:23:08]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2017-05-12 07:23:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 08:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:37:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jens Widell, 2017-05-12 09:37:34]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2017-05-12 09:37:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 10:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 10:46:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jens Widell, 2017-05-12 12:16:33]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2017-05-12 12:16:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 12:36:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494591393972210,
"parent_rev": "4d83ef17a6e7f586f32f7c894e0bb11187c72a8d", "commit_rev":
"2a32710d5f0e31cf648120a9724d5c8b0d8e5a88"}

[commit-bot: I haz the power, 2017-05-12 12:36:46]

Description was changed from

==========
Inherit [Unforgeable] attributes between components

Specifically, when an interface in modules/ inherits an interface in core/
that defines an [Unforgeable] attribute, the interface in modules/ should
still have the attribute.

BUG=712070
==========

to

==========
Inherit [Unforgeable] attributes between components

Specifically, when an interface in modules/ inherits an interface in core/
that defines an [Unforgeable] attribute, the interface in modules/ should
still have the attribute.

BUG=712070

Review-Url: https://codereview.chromium.org/2874153003
Cr-Commit-Position: refs/heads/master@{#471284}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a32710d5f0e31cf648120a9724d...
==========

[commit-bot: I haz the power, 2017-05-12 12:36:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a32710d5f0e31cf648120a9724d...