third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py - Issue 2874153003: Inherit [Unforgeable] attributes between components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

Issue 2874153003: Inherit [Unforgeable] attributes between components (Closed)

Patch Set: update Document-createEvent-expected.txt Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py ('k') | third_party/WebKit/Source/bindings/tests/idls/modules/TestSubObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

diff --git a/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py b/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

index 5a032ed2d27402592a7c288064bdc467c15983d6..2506bb6a45aad8b4a8de2054eb658d5b723072eb 100644

--- a/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

+++ b/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

@@ -320,9 +320,9 @@ def inherit_unforgeable_attributes(resolved_definitions, interfaces_info):

"""Inherits [Unforgeable] attributes and updates the arguments accordingly.

For each interface in |resolved_definitions|, collects all [Unforgeable]

- attributes in ancestor interfaces in the same component and adds them to

- the interface. 'referenced_interfaces' and 'cpp_includes' in

- |interfaces_info| are updated accordingly.

+ attributes in ancestor interfaces and adds them to the interface.

+ 'referenced_interfaces' and 'cpp_includes' in |interfaces_info| are updated

+ accordingly.

"""

def collect_unforgeable_attributes_in_ancestors(interface_name, component):

if not interface_name:

@@ -330,7 +330,7 @@ def inherit_unforgeable_attributes(resolved_definitions, interfaces_info):

return [], [], set()

interface = interfaces_info[interface_name]

unforgeable_attributes, referenced_interfaces, cpp_includes = collect_unforgeable_attributes_in_ancestors(interface.get('parent'), component)

- this_unforgeable = interface.get('unforgeable_attributes', {}).get(component, [])

+ this_unforgeable = interface.get('unforgeable_attributes', [])

unforgeable_attributes.extend(this_unforgeable)

this_referenced = [attr.idl_type.base_type for attr in this_unforgeable

if attr.idl_type.base_type in