third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py - Issue 2874153003: Inherit [Unforgeable] attributes between components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

Issue 2874153003: Inherit [Unforgeable] attributes between components (Closed)

Patch Set: update Document-createEvent-expected.txt Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt ('k') | third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

index e7d40988c351a0ed76cceb7b253a0522c2df2971..510d438ee27dcd871327f0a77a4b4b719daeee87 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

@@ -190,10 +190,7 @@ class InterfaceInfoCollector(object):

"""Collects [Unforgeable] attributes so that we can define them on

sub-interfaces later. The resulting structure is as follows.

interfaces_info[interface_name] = {

- 'unforgeable_attributes': {

- 'core': [IdlAttribute, ...],

- 'modules': [IdlAttribute, ...],

- },

+ 'unforgeable_attributes': [IdlAttribute, ...],

...

}

"""

@@ -209,9 +206,7 @@ class InterfaceInfoCollector(object):

# Come up with a better way to keep them consistent.

for attr in unforgeable_attributes:

attr.extended_attributes['PartialInterfaceImplementedAs'] = definition.extended_attributes.get('ImplementedAs', interface_basename)

- component = idl_filename_to_component(idl_filename)

- interface_info['unforgeable_attributes'] = {}

- interface_info['unforgeable_attributes'][component] = unforgeable_attributes

+ interface_info['unforgeable_attributes'] = unforgeable_attributes

return interface_info

definitions = self.reader.read_idl_file(idl_filename)