Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dshwang, Eric Willigers, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+serviceworker, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mac-reviews_chromium.org, michaeln, nhiroki, pfeldman+blink_chromium.org, rjwright, serviceworker-reviews, shans, shimazu+serviceworker_chromium.org, tzik, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK_EQ as appropriate BUG=596760 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2873293002 Cr-Commit-Position: refs/heads/master@{#471834} Committed: https://chromium.googlesource.com/chromium/src/+/a469806c5653b6fae16b055d017f0c55cfaf9a59

Patch Set 1 #

Patch Set 2 : DCHECK in several places where types don't match #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
pilgrim_google
3 years, 7 months ago (2017-05-10 13:36:05 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-05-10 13:54:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873293002/1
3 years, 7 months ago (2017-05-10 14:16:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/415190) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-10 14:33:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873293002/20001
3 years, 7 months ago (2017-05-10 15:22:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450265)
3 years, 7 months ago (2017-05-10 17:51:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873293002/20001
3 years, 7 months ago (2017-05-11 17:40:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/267437) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-11 17:45:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873293002/40001
3 years, 7 months ago (2017-05-15 16:40:15 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:22:41 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a469806c5653b6fae16b055d017f...

Powered by Google App Engine
This is Rietveld 408576698