3 years, 7 months ago
(2017-05-10 13:36:05 UTC)
#2
pilgrim_google
Description was changed from ========== Replace ASSERT with DCHECK_EQ as appropriate BUG=596760 ========== to ========== ...
3 years, 7 months ago
(2017-05-10 13:36:12 UTC)
#3
Description was changed from
==========
Replace ASSERT with DCHECK_EQ as appropriate
BUG=596760
==========
to
==========
Replace ASSERT with DCHECK_EQ as appropriate
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
haraken
LGTM
3 years, 7 months ago
(2017-05-10 13:54:36 UTC)
#4
LGTM
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
3 years, 7 months ago
(2017-05-10 14:16:16 UTC)
#5
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/415190) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago
(2017-05-10 14:33:39 UTC)
#8
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450265)
3 years, 7 months ago
(2017-05-10 17:51:27 UTC)
#13
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/267437) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago
(2017-05-11 17:45:51 UTC)
#17
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494866377801430, "parent_rev": "6dbb86d4a6bd9aacd50573b3473afaa857bca4c3", "commit_rev": "a469806c5653b6fae16b055d017f0c55cfaf9a59"}
3 years, 7 months ago
(2017-05-15 18:22:21 UTC)
#21
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494866377801430,
"parent_rev": "6dbb86d4a6bd9aacd50573b3473afaa857bca4c3", "commit_rev":
"a469806c5653b6fae16b055d017f0c55cfaf9a59"}
commit-bot: I haz the power
Description was changed from ========== Replace ASSERT with DCHECK_EQ as appropriate BUG=596760 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ...
3 years, 7 months ago
(2017-05-15 18:22:40 UTC)
#22
Message was sent while issue was closed.
Description was changed from
==========
Replace ASSERT with DCHECK_EQ as appropriate
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Replace ASSERT with DCHECK_EQ as appropriate
BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2873293002
Cr-Commit-Position: refs/heads/master@{#471834}
Committed:
https://chromium.googlesource.com/chromium/src/+/a469806c5653b6fae16b055d017f...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a469806c5653b6fae16b055d017f0c55cfaf9a59
3 years, 7 months ago
(2017-05-15 18:22:41 UTC)
#23
Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate
(Closed)
Created 3 years, 7 months ago by pilgrim_google
Modified 3 years, 7 months ago
Reviewers: haraken, tkent
Base URL:
Comments: 0