third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp - Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp

Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp

diff --git a/third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp b/third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp

index ca07acf61aa055c0db464ea7d81f74c4ded7e368..ef2ae2f05f630f142a03f20cda0b907d2066b6ff 100644

--- a/third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp

+++ b/third_party/WebKit/Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp

@@ -22,7 +22,7 @@ DeprecatedScheduleStyleRecalcDuringLayout::

// proper state. The style recalc will still have been schedule, however.

if (was_in_perform_layout_ &&

lifecycle_.GetState() != DocumentLifecycle::kInPerformLayout) {

- ASSERT(lifecycle_.GetState() == DocumentLifecycle::kVisualUpdatePending);

+ DCHECK_EQ(lifecycle_.GetState(), DocumentLifecycle::kVisualUpdatePending);

lifecycle_.AdvanceTo(DocumentLifecycle::kInPerformLayout);

}

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »