third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp - Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

index 8dd5d0df672ca8da1c1bb8677c3b7b17391971d5..ae92d3edea0c2875fa8c5a0ce900dfbd0cb04e63 100644

--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

@@ -101,7 +101,7 @@ void SQLiteDatabase::Close() {

if (db_) {

// FIXME: This is being called on the main thread during JS GC.

// <rdar://problem/5739818>

- // ASSERT(currentThread() == m_openingThread);

+ // DCHECK_EQ(currentThread(), m_openingThread);

sqlite3* db = db_;

{

MutexLocker locker(database_closing_mutex_);