third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp - Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

Issue 2873293002: Replace ASSERT with DCHECK_EQ as appropriate (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

index 084583ee1495ccd2c116a0f6f41b790da19d48e5..59b3511990c8f11b6f0e9765218dd0afe10d9da1 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp

@@ -22,7 +22,7 @@ int DOMTimerCoordinator::InstallNewTimeout(ExecutionContext* context,

int timeout,

bool single_shot) {

// FIXME: DOMTimers depends heavily on ExecutionContext. Decouple them.

- ASSERT(context->Timers() == this);

+ DCHECK_EQ(context->Timers(), this);

int timeout_id = NextID();

timers_.insert(timeout_id, DOMTimer::Create(context, action, timeout,

single_shot, timeout_id));