Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2871993003: Moving the iOS directory to be remoting top level. (Closed)

Created:
3 years, 7 months ago by nicholss
Modified:
3 years, 7 months ago
Reviewers:
Yuwei, jam
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving the iOS directory to be remoting top level. The remoting/client directory is intended for shared client code. But the iOS directory is a whole client. Moving it to be more inline with Android and webapp. Review-Url: https://codereview.chromium.org/2871993003 Cr-Commit-Position: refs/heads/master@{#470603} Committed: https://chromium.googlesource.com/chromium/src/+/ed15807589e8d79691b1e9e5673f1d8b9b3a7fa0

Patch Set 1 #

Patch Set 2 : Fixing h file guards. #

Patch Set 3 : Merge branch 'master' into move_ios #

Patch Set 4 : //remoting/ios was the old landing target for the internal iOS application. Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -6031 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D remoting/client/ios/BUILD.gn View 1 chunk +0 lines, -89 lines 0 comments Download
D remoting/client/ios/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D remoting/client/ios/app/BUILD.gn View 1 chunk +0 lines, -108 lines 0 comments Download
D remoting/client/ios/app/app_delegate.h View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/client/ios/app/app_delegate.mm View 1 chunk +0 lines, -62 lines 0 comments Download
D remoting/client/ios/app/client_connection_view_controller.h View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/client/ios/app/client_connection_view_controller.mm View 1 chunk +0 lines, -323 lines 0 comments Download
D remoting/client/ios/app/host_collection_view_cell.h View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/host_collection_view_cell.mm View 1 chunk +0 lines, -127 lines 0 comments Download
D remoting/client/ios/app/host_collection_view_controller.h View 1 chunk +0 lines, -43 lines 0 comments Download
D remoting/client/ios/app/host_collection_view_controller.mm View 1 chunk +0 lines, -152 lines 0 comments Download
D remoting/client/ios/app/host_view_controller.h View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/host_view_controller.mm View 1 chunk +0 lines, -118 lines 0 comments Download
D remoting/client/ios/app/main.mm View 1 chunk +0 lines, -33 lines 0 comments Download
D remoting/client/ios/app/pin_entry_view.h View 1 chunk +0 lines, -28 lines 0 comments Download
D remoting/client/ios/app/pin_entry_view.mm View 1 chunk +0 lines, -123 lines 0 comments Download
D remoting/client/ios/app/remoting_settings_view_controller.h View 1 chunk +0 lines, -13 lines 0 comments Download
D remoting/client/ios/app/remoting_settings_view_controller.mm View 1 chunk +0 lines, -208 lines 0 comments Download
D remoting/client/ios/app/remoting_view_controller.h View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/client/ios/app/remoting_view_controller.mm View 1 chunk +0 lines, -296 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_1x_ios_36dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_2x_ios_36dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_3x_ios_36dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Contents.json View 1 chunk +0 lines, -6 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_1x_ios_24dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_2x_ios_24dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_3x_ios_24dp.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/Contents.json View 1 chunk +0 lines, -24 lines 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/BUILD.gn View 1 chunk +0 lines, -74 lines 0 comments Download
D remoting/client/ios/app/resources/Info.plist View 1 chunk +0 lines, -80 lines 0 comments Download
D remoting/client/ios/app/resources/LaunchScreen.storyboard View 1 chunk +0 lines, -37 lines 0 comments Download
D remoting/client/ios/app/resources/Remoting.entitlements View 1 chunk +0 lines, -17 lines 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-120.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-152.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-167.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-180.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-29.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-40.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-58.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-76.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-80.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/chromium/Icon-87.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/Contents.json View 1 chunk +0 lines, -6 lines 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@3x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/Contents.json View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@2x.png View Binary file 0 comments Download
D remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@3x.png View Binary file 0 comments Download
D remoting/client/ios/build/InfoPlist.strings.jinja2 View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/client/ios/build/localizable_string_id_list.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D remoting/client/ios/client_gestures.h View 1 chunk +0 lines, -72 lines 0 comments Download
D remoting/client/ios/client_gestures.mm View 1 chunk +0 lines, -358 lines 0 comments Download
D remoting/client/ios/display/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D remoting/client/ios/display/gl_demo_screen.h View 1 chunk +0 lines, -40 lines 0 comments Download
D remoting/client/ios/display/gl_demo_screen.mm View 1 chunk +0 lines, -115 lines 0 comments Download
D remoting/client/ios/display/gl_display_handler.h View 1 chunk +0 lines, -62 lines 0 comments Download
D remoting/client/ios/display/gl_display_handler.mm View 1 chunk +0 lines, -280 lines 0 comments Download
D remoting/client/ios/domain/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D remoting/client/ios/domain/client_session_details.h View 1 chunk +0 lines, -35 lines 0 comments Download
D remoting/client/ios/domain/client_session_details.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D remoting/client/ios/domain/host_info.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/client/ios/domain/host_info.mm View 1 chunk +0 lines, -82 lines 0 comments Download
D remoting/client/ios/domain/user_info.h View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/client/ios/domain/user_info.mm View 1 chunk +0 lines, -52 lines 0 comments Download
D remoting/client/ios/facade/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/client/ios/facade/host_info.h View 1 chunk +0 lines, -41 lines 0 comments Download
D remoting/client/ios/facade/host_info.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D remoting/client/ios/facade/host_list_fetcher.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/client/ios/facade/host_list_fetcher.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D remoting/client/ios/facade/ios_client_runtime_delegate.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/client/ios/facade/ios_client_runtime_delegate.mm View 1 chunk +0 lines, -71 lines 0 comments Download
D remoting/client/ios/facade/remoting_authentication.h View 1 chunk +0 lines, -51 lines 0 comments Download
D remoting/client/ios/facade/remoting_authentication.mm View 1 chunk +0 lines, -195 lines 0 comments Download
D remoting/client/ios/facade/remoting_service.h View 1 chunk +0 lines, -50 lines 0 comments Download
D remoting/client/ios/facade/remoting_service.mm View 1 chunk +0 lines, -176 lines 0 comments Download
D remoting/client/ios/host_preferences.h View 1 chunk +0 lines, -28 lines 0 comments Download
D remoting/client/ios/host_preferences.mm View 1 chunk +0 lines, -92 lines 0 comments Download
D remoting/client/ios/host_preferences_persistence.h View 1 chunk +0 lines, -21 lines 0 comments Download
D remoting/client/ios/host_preferences_persistence_chromium.mm View 1 chunk +0 lines, -28 lines 0 comments Download
D remoting/client/ios/key_input.h View 1 chunk +0 lines, -39 lines 0 comments Download
D remoting/client/ios/key_input.mm View 1 chunk +0 lines, -150 lines 0 comments Download
D remoting/client/ios/key_input_unittest.mm View 1 chunk +0 lines, -150 lines 0 comments Download
D remoting/client/ios/key_map_us.h View 1 chunk +0 lines, -160 lines 0 comments Download
D remoting/client/ios/keychain_wrapper.h View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/client/ios/keychain_wrapper.mm View 1 chunk +0 lines, -206 lines 0 comments Download
D remoting/client/ios/session/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/client/ios/session/remoting_client.h View 1 chunk +0 lines, -83 lines 0 comments Download
D remoting/client/ios/session/remoting_client.mm View 1 chunk +0 lines, -238 lines 0 comments Download
D remoting/client/ios/session/remoting_client_session_delegate.h View 1 chunk +0 lines, -51 lines 0 comments Download
D remoting/client/ios/session/remoting_client_session_delegate.mm View 1 chunk +0 lines, -81 lines 0 comments Download
A + remoting/ios/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/ios/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
A + remoting/ios/app/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
A + remoting/ios/app/app_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/app_delegate.mm View 1 chunk +4 lines, -4 lines 0 comments Download
A + remoting/ios/app/client_connection_view_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/client_connection_view_controller.mm View 1 chunk +4 lines, -4 lines 0 comments Download
A + remoting/ios/app/host_collection_view_cell.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/host_collection_view_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/app/host_collection_view_controller.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + remoting/ios/app/host_collection_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/app/host_view_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/ios/app/host_view_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/main.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/app/pin_entry_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/pin_entry_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/app/remoting_settings_view_controller.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/remoting_settings_view_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/ios/app/remoting_view_controller.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + remoting/ios/app/remoting_view_controller.mm View 1 chunk +9 lines, -9 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Back.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_1x_ios_36dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_2x_ios_36dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_3x_ios_36dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Settings.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_1x_ios_24dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_2x_ios_24dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_3x_ios_24dp.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Info.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/LaunchScreen.storyboard View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/Remoting.entitlements View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-120.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-152.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-167.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-180.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-29.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-40.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-58.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-76.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-80.png View Binary file 0 comments Download
A + remoting/ios/app/resources/chromium/Icon-87.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/Contents.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@2x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@3x.png View Binary file 0 comments Download
A + remoting/ios/build/InfoPlist.strings.jinja2 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/build/localizable_string_id_list.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/client_gestures.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/ios/client_gestures.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/display/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/display/gl_demo_screen.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/display/gl_demo_screen.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/display/gl_display_handler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/display/gl_display_handler.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/domain/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/ios/domain/client_session_details.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/domain/client_session_details.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/domain/host_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/domain/host_info.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/domain/user_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/domain/user_info.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/facade/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/facade/host_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/facade/host_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/facade/host_list_fetcher.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + remoting/ios/facade/host_list_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/facade/ios_client_runtime_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/facade/ios_client_runtime_delegate.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/ios/facade/remoting_authentication.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/ios/facade/remoting_authentication.mm View 1 chunk +6 lines, -6 lines 0 comments Download
A + remoting/ios/facade/remoting_service.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/facade/remoting_service.mm View 1 chunk +9 lines, -9 lines 0 comments Download
A + remoting/ios/host_preferences.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/host_preferences.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/host_preferences_persistence.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/host_preferences_persistence_chromium.mm View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/ios/key_input.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/key_input.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/key_input_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/key_map_us.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/keychain_wrapper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/keychain_wrapper.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/session/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/ios/session/remoting_client.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/ios/session/remoting_client.mm View 1 chunk +5 lines, -5 lines 0 comments Download
A + remoting/ios/session/remoting_client_session_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/ios/session/remoting_client_session_delegate.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
nicholss
This is a code move only. Nothing functional has changed and no formatting. Just moving ...
3 years, 7 months ago (2017-05-09 21:15:09 UTC) #2
Yuwei
LGTM
3 years, 7 months ago (2017-05-09 21:30:19 UTC) #10
jam
On 2017/05/09 21:15:09, nicholss wrote: > This is a code move only. Nothing functional has ...
3 years, 7 months ago (2017-05-09 22:03:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871993003/80001
3 years, 7 months ago (2017-05-10 16:25:25 UTC) #28
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:39:39 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ed15807589e8d79691b1e9e5673f...

Powered by Google App Engine
This is Rietveld 408576698