Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(411)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: remoting/ios/display/BUILD.gn
Issue
2871993003
:
Moving the iOS directory to be remoting top level. (Closed)
Patch Set: //remoting/ios was the old landing target for the internal iOS application. Fix.
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
.gitignore
remoting/BUILD.gn
remoting/client/ios/BUILD.gn
remoting/client/ios/DEPS
remoting/client/ios/app/BUILD.gn
remoting/client/ios/app/app_delegate.h
remoting/client/ios/app/app_delegate.mm
remoting/client/ios/app/client_connection_view_controller.h
remoting/client/ios/app/client_connection_view_controller.mm
remoting/client/ios/app/host_collection_view_cell.h
remoting/client/ios/app/host_collection_view_cell.mm
remoting/client/ios/app/host_collection_view_controller.h
remoting/client/ios/app/host_collection_view_controller.mm
remoting/client/ios/app/host_view_controller.h
remoting/client/ios/app/host_view_controller.mm
remoting/client/ios/app/main.mm
remoting/client/ios/app/pin_entry_view.h
remoting/client/ios/app/pin_entry_view.mm
remoting/client/ios/app/remoting_settings_view_controller.h
remoting/client/ios/app/remoting_settings_view_controller.mm
remoting/client/ios/app/remoting_view_controller.h
remoting/client/ios/app/remoting_view_controller.mm
remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_1x_ios_36dp.png
remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_2x_ios_36dp.png
remoting/client/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_3x_ios_36dp.png
remoting/client/ios/app/resources/Assets.xcassets/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_1x_ios_24dp.png
remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_2x_ios_24dp.png
remoting/client/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_3x_ios_24dp.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@3x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@3x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@3x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@3x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse.png
remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@3x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/Contents.json
remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app.png
remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_2x.png
remoting/client/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_3x.png
remoting/client/ios/app/resources/BUILD.gn
remoting/client/ios/app/resources/Info.plist
remoting/client/ios/app/resources/LaunchScreen.storyboard
remoting/client/ios/app/resources/Remoting.entitlements
remoting/client/ios/app/resources/chromium/Icon-120.png
remoting/client/ios/app/resources/chromium/Icon-152.png
remoting/client/ios/app/resources/chromium/Icon-167.png
remoting/client/ios/app/resources/chromium/Icon-180.png
remoting/client/ios/app/resources/chromium/Icon-29.png
remoting/client/ios/app/resources/chromium/Icon-40.png
remoting/client/ios/app/resources/chromium/Icon-58.png
remoting/client/ios/app/resources/chromium/Icon-76.png
remoting/client/ios/app/resources/chromium/Icon-80.png
remoting/client/ios/app/resources/chromium/Icon-87.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/Contents.json
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/Contents.json
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@2x.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@3x.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/Contents.json
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@2x.png
remoting/client/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@3x.png
remoting/client/ios/build/InfoPlist.strings.jinja2
remoting/client/ios/build/localizable_string_id_list.txt
remoting/client/ios/client_gestures.h
remoting/client/ios/client_gestures.mm
remoting/client/ios/display/BUILD.gn
remoting/client/ios/display/gl_demo_screen.h
remoting/client/ios/display/gl_demo_screen.mm
remoting/client/ios/display/gl_display_handler.h
remoting/client/ios/display/gl_display_handler.mm
remoting/client/ios/domain/BUILD.gn
remoting/client/ios/domain/client_session_details.h
remoting/client/ios/domain/client_session_details.mm
remoting/client/ios/domain/host_info.h
remoting/client/ios/domain/host_info.mm
remoting/client/ios/domain/user_info.h
remoting/client/ios/domain/user_info.mm
remoting/client/ios/facade/BUILD.gn
remoting/client/ios/facade/host_info.h
remoting/client/ios/facade/host_info.cc
remoting/client/ios/facade/host_list_fetcher.h
remoting/client/ios/facade/host_list_fetcher.cc
remoting/client/ios/facade/ios_client_runtime_delegate.h
remoting/client/ios/facade/ios_client_runtime_delegate.mm
remoting/client/ios/facade/remoting_authentication.h
remoting/client/ios/facade/remoting_authentication.mm
remoting/client/ios/facade/remoting_service.h
remoting/client/ios/facade/remoting_service.mm
remoting/client/ios/host_preferences.h
remoting/client/ios/host_preferences.mm
remoting/client/ios/host_preferences_persistence.h
remoting/client/ios/host_preferences_persistence_chromium.mm
remoting/client/ios/key_input.h
remoting/client/ios/key_input.mm
remoting/client/ios/key_input_unittest.mm
remoting/client/ios/key_map_us.h
remoting/client/ios/keychain_wrapper.h
remoting/client/ios/keychain_wrapper.mm
remoting/client/ios/session/BUILD.gn
remoting/client/ios/session/remoting_client.h
remoting/client/ios/session/remoting_client.mm
remoting/client/ios/session/remoting_client_session_delegate.h
remoting/client/ios/session/remoting_client_session_delegate.mm
remoting/ios/BUILD.gn
remoting/ios/DEPS
remoting/ios/app/BUILD.gn
remoting/ios/app/app_delegate.h
remoting/ios/app/app_delegate.mm
remoting/ios/app/client_connection_view_controller.h
remoting/ios/app/client_connection_view_controller.mm
remoting/ios/app/host_collection_view_cell.h
remoting/ios/app/host_collection_view_cell.mm
remoting/ios/app/host_collection_view_controller.h
remoting/ios/app/host_collection_view_controller.mm
remoting/ios/app/host_view_controller.h
remoting/ios/app/host_view_controller.mm
remoting/ios/app/main.mm
remoting/ios/app/pin_entry_view.h
remoting/ios/app/pin_entry_view.mm
remoting/ios/app/remoting_settings_view_controller.h
remoting/ios/app/remoting_settings_view_controller.mm
remoting/ios/app/remoting_view_controller.h
remoting/ios/app/remoting_view_controller.mm
remoting/ios/app/resources/Assets.xcassets/Back.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_1x_ios_36dp.png
remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_2x_ios_36dp.png
remoting/ios/app/resources/Assets.xcassets/Back.imageset/ic_keyboard_arrow_left_white_3x_ios_36dp.png
remoting/ios/app/resources/Assets.xcassets/Contents.json
remoting/ios/app/resources/Assets.xcassets/Settings.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_1x_ios_24dp.png
remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_2x_ios_24dp.png
remoting/ios/app/resources/Assets.xcassets/Settings.imageset/ic_settings_white_3x_ios_24dp.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@2x.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop.imageset/ic_desktop@3x.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@2x.png
remoting/ios/app/resources/Assets.xcassets/ic_desktop_windows.imageset/ic_desktop_windows@3x.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@2x.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen.imageset/ic_fullscreen@3x.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@2x.png
remoting/ios/app/resources/Assets.xcassets/ic_fullscreen_exit.imageset/ic_fullscreen_exit@3x.png
remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse.png
remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@2x.png
remoting/ios/app/resources/Assets.xcassets/ic_mouse.imageset/ic_mouse@3x.png
remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/Contents.json
remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app.png
remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_2x.png
remoting/ios/app/resources/Assets.xcassets/ic_touch_app.imageset/ic_touch_app_3x.png
remoting/ios/app/resources/BUILD.gn
remoting/ios/app/resources/Info.plist
remoting/ios/app/resources/LaunchScreen.storyboard
remoting/ios/app/resources/Remoting.entitlements
remoting/ios/app/resources/chromium/Icon-120.png
remoting/ios/app/resources/chromium/Icon-152.png
remoting/ios/app/resources/chromium/Icon-167.png
remoting/ios/app/resources/chromium/Icon-180.png
remoting/ios/app/resources/chromium/Icon-29.png
remoting/ios/app/resources/chromium/Icon-40.png
remoting/ios/app/resources/chromium/Icon-58.png
remoting/ios/app/resources/chromium/Icon-76.png
remoting/ios/app/resources/chromium/Icon-80.png
remoting/ios/app/resources/chromium/Icon-87.png
remoting/ios/app/resources/launchscreen_images.xcassets/Contents.json
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/Contents.json
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo.png
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@2x.png
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_app_logo.imageset/launchscreen_app_logo@3x.png
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/Contents.json
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name.png
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@2x.png
remoting/ios/app/resources/launchscreen_images.xcassets/launchscreen_brand_name.imageset/launchscreen_brand_name@3x.png
remoting/ios/build/InfoPlist.strings.jinja2
remoting/ios/build/localizable_string_id_list.txt
remoting/ios/client_gestures.h
remoting/ios/client_gestures.mm
remoting/ios/display/BUILD.gn
remoting/ios/display/gl_demo_screen.h
remoting/ios/display/gl_demo_screen.mm
remoting/ios/display/gl_display_handler.h
remoting/ios/display/gl_display_handler.mm
remoting/ios/domain/BUILD.gn
remoting/ios/domain/client_session_details.h
remoting/ios/domain/client_session_details.mm
remoting/ios/domain/host_info.h
remoting/ios/domain/host_info.mm
remoting/ios/domain/user_info.h
remoting/ios/domain/user_info.mm
remoting/ios/facade/BUILD.gn
remoting/ios/facade/host_info.h
remoting/ios/facade/host_info.cc
remoting/ios/facade/host_list_fetcher.h
remoting/ios/facade/host_list_fetcher.cc
remoting/ios/facade/ios_client_runtime_delegate.h
remoting/ios/facade/ios_client_runtime_delegate.mm
remoting/ios/facade/remoting_authentication.h
remoting/ios/facade/remoting_authentication.mm
remoting/ios/facade/remoting_service.h
remoting/ios/facade/remoting_service.mm
remoting/ios/host_preferences.h
remoting/ios/host_preferences.mm
remoting/ios/host_preferences_persistence.h
remoting/ios/host_preferences_persistence_chromium.mm
remoting/ios/key_input.h
remoting/ios/key_input.mm
remoting/ios/key_input_unittest.mm
remoting/ios/key_map_us.h
remoting/ios/keychain_wrapper.h
remoting/ios/keychain_wrapper.mm
remoting/ios/session/BUILD.gn
remoting/ios/session/remoting_client.h
remoting/ios/session/remoting_client.mm
remoting/ios/session/remoting_client_session_delegate.h
remoting/ios/session/remoting_client_session_delegate.mm
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« remoting/ios/client_gestures.mm
('k') |
remoting/ios/display/gl_demo_screen.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: remoting/ios/display/BUILD.gn
diff --git a/remoting/client/ios/display/BUILD.gn b/remoting/ios/display/BUILD.gn
similarity index 100%
rename from remoting/client/ios/display/BUILD.gn
rename to remoting/ios/display/BUILD.gn
« no previous file with comments
|
« remoting/ios/client_gestures.mm
('k') |
remoting/ios/display/gl_demo_screen.h »
('j') |
no next file with comments »
Issue 2871993003: Moving the iOS directory to be remoting top level. (Closed)
Created 3 years, 7 months ago by nicholss
Modified 3 years, 7 months ago
Reviewers: jam, Yuwei
Base URL:
Comments: 0
This is Rietveld
408576698