win: Set is_clang=true by default.

win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690, 82385
Review-Url: https://codereview.chromium.org/2870543003
Cr-Commit-Position: refs/heads/master@{#475401}
Committed: https://chromium.googlesource.com/chromium/src/+/d560ed865c053d87594aca8a72637593117d5d1b

[Nico, 2017-05-08 20:09:59]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 20:11:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:21:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-09 02:19:36]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 02:21:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 07:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 07:07:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2017-05-12 17:02:04]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 17:02:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 17:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:10:38]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nico, 2017-05-15 15:36:18]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 15:37:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 17:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 17:17:06]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hans, 2017-05-15 17:22:43]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2017-05-15 17:22:43]

LGTM

BUG=82385?

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1503: # TODO(thakis): Now that the default win bots uss
clang, use win_clang
s/uss/use/

[Nico, 2017-05-15 17:23:27]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 17:24:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-15 17:24:28]

On 2017/05/15 17:22:43, hans wrote:
> LGTM
> 
> BUG=82385?
> 
> https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl
> File tools/mb/mb_config.pyl (right):
> 
>
https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl#...
> tools/mb/mb_config.pyl:1503: # TODO(thakis): Now that the default win bots uss
> clang, use win_clang
> s/uss/use/

Goma troubles (see posts on goma-users), we won't get reliable try results
today.

[commit-bot: I haz the power, 2017-05-15 21:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:09:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-16 16:20:03]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:20:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-16 21:37:53]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=XXX
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=XXX
==========

[Nico, 2017-05-16 21:38:04]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=XXX
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

[Nico, 2017-05-16 21:39:37]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

This switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

[Nico, 2017-05-16 22:37:28]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-05-16 22:37:36]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:39:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:48:12]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-17 22:02:03]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

This switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be very slow. Try setting use_win_fastbuild=true in
args.gn

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

This switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

[hans, 2017-05-17 22:08:37]

patch set 4 lgtm too

[Nico, 2017-05-17 22:09:23]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 22:11:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-17 22:14:16]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

This switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

[Nico, 2017-05-17 22:27:48]

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1629: 'gn_args': 'is_clang=true',
whooooooooops

[Nico, 2017-05-17 22:28:31]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 22:29:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-17 22:30:03]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

[Nico, 2017-05-17 22:31:44]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2017-05-17 22:31:45]

+brettw for BUILDCONFIG which is noparent

[Nico, 2017-05-17 22:34:55]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 1-2 days if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

[hans, 2017-05-17 22:36:46]

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2870543003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1629: 'gn_args': 'is_clang=true',
On 2017/05/17 22:27:48, Nico wrote:
> whooooooooops

But it said no_clang on the tin!

[Nico, 2017-05-17 22:39:02]

thakis@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2017-05-17 22:57:17]

I like the idea. lgtm with a couple of questions/nits.

Also, I understand this doesn't affect what we ship, but maybe mention that we
already ship some percentage of clang builds.

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:141: 'CrWinClang(shared)':
'clang_minimal_symbols_shared_release_bot_x86',
How come these two got moved? Alternately, how come the other CrWinClang entries
*didn't* get moved?

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1063: # check that is very confusing, so rename the bot
to win_msvc.
It's not clear which part of this the TODO refers to. I think it is just the
second sentence, so move the TODO to represent that?

[Nico, 2017-05-17 23:01:19]

Thanks!

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:141: 'CrWinClang(shared)':
'clang_minimal_symbols_shared_release_bot_x86',
On 2017/05/17 22:57:17, brucedawson wrote:
> How come these two got moved? Alternately, how come the other CrWinClang
entries
> *didn't* get moved?

I was looking through the bot names on
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang (which
has the fyi clang bots with pinned clang). The other CrWinClang (lld) bots
confusingly use trunk clang and should really be called ClangToTWin.

https://codereview.chromium.org/2870543003/diff/80001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1063: # check that is very confusing, so rename the bot
to win_msvc.
On 2017/05/17 22:57:17, brucedawson wrote:
> It's not clear which part of this the TODO refers to. I think it is just the
> second sentence, so move the TODO to represent that?

Done.

[Nico, 2017-05-17 23:04:25]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:05:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-05-17 23:14:28]

While this is exciting, it's a substantial change and so it warrants larger
discussion with more data.

Can you start a thread on an appropriate mailing list (chrome-windows?) first to
get a discussion going?

We need some more data as well, such as:
-how much does it slow down building? (debug vs release, incremental builds) 
-what are the build times with goma?
(for the above two, please use z840 since that's what windows devs at google
primarily use)
-any changes to debugging with Visual Studio?
-anything else that could impact developers on windows?

[jam, 2017-05-17 23:14:44]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[Nico, 2017-05-17 23:19:25]

On 2017/05/17 23:14:28, jam wrote:
> While this is exciting, it's a substantial change and so it warrants larger
> discussion with more data.
> 
> Can you start a thread on an appropriate mailing list (chrome-windows?) first
to
> get a discussion going?
> 
> We need some more data as well, such as:
> -how much does it slow down building? (debug vs release, incremental builds) 
> -what are the build times with goma?
> (for the above two, please use z840 since that's what windows devs at google
> primarily use)
> -any changes to debugging with Visual Studio?
> -anything else that could impact developers on windows?

We have discussed this in high detail with many people at various conferences.
See
https://groups.google.com/a/google.com/forum/#!topic/chrome-desktop/kKzbvlB3Zfw
for the last update,
https://docs.google.com/document/d/1yoW7U0fTDo5Yp4m5KTqo-oea2w5HobDoplppwSnYY...
for a doc with a bunch of numbers from a while ago,
https://groups.google.com/a/google.com/forum/#!topic/chrome-windows/Au_AYn4ys4Q
for recent build time data. Debugging should Just Work, see blockers of
https://bugs.chromium.org/p/chromium/issues/detail?id=636111 for debugging
experience things (all known issues fixed; the one open bug has a fix in
https://codereview.chromium.org/2884383004 that should make it in before this CL
here lands.

(We've been trying to find stakeholders who are interested in this for months
now.)

[commit-bot: I haz the power, 2017-05-18 03:05:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:05:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-18 03:09:20]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:10:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 08:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 08:24:38]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-05-18 17:41:26]

I'm not following the threads but I'll give an owners LGTM so you can submit
this when everything is ready.

[Nico, 2017-05-22 21:23:03]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:23:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:26:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-26 15:41:31]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 15:42:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:19:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nico, 2017-05-26 21:28:23]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:29:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 23:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:21:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-27 11:59:29]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 11:59:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 13:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 13:52:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2017-05-29 13:37:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 13:37:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 15:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 15:31:25]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-30 01:00:46]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 1-2 days if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

[Nico, 2017-05-30 01:00:55]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-05-30 01:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org,
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2870543003/#ps100001
(title: "comment")

[commit-bot: I haz the power, 2017-05-30 01:01:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 01:04:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496106055129070,
"parent_rev": "5389373c6dec30d783eb46b4c8190720f411a8a7", "commit_rev":
"d560ed865c053d87594aca8a72637593117d5d1b"}

[commit-bot: I haz the power, 2017-05-30 01:05:06]

Description was changed from

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385
==========

to

==========
win: Set is_clang=true by default.

To figure out unknown problems. If this inconveniences you in any way, please
do let us know (ideally on crbug.com) – finding annoying things are part of the
motivation for this change.

If this breaks anything, please revert with prejudice -- but file a bug for
us about what went wrong. We intend to revert this in 5 hours if it's not
reverted earlier due to breaking something.

This also switches win_clang to use MSVC as compiler, to make sure things stay
compilable with both compilers even while this is in.

Known problems:
* build times without goma are slower (but you can do goma builds with debug
  info, which are faster)
* incremental linking of webcore.dll doesn't work, so if you work on blink
  on windows links will be slow. If this affects you, please star
  https://crbug.com/717207 and make yourself heard.

This doesn't affect what we ship, which is currently off an PGO builder.

BUG=709690,82385

Review-Url: https://codereview.chromium.org/2870543003
Cr-Commit-Position: refs/heads/master@{#475401}
Committed:
https://chromium.googlesource.com/chromium/src/+/d560ed865c053d87594aca8a7263...
==========

[commit-bot: I haz the power, 2017-05-30 01:05:07]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d560ed865c053d87594aca8a7263...

[kjellander_chromium, 2017-05-30 07:00:49]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2907363002/ by kjellander@chromium.org.

The reason for reverting is: Breaks many tests:
goma errors https://bugs.chromium.org/p/chromium/issues/detail?id=727488 
webkit_tests is https://bugs.chromium.org/p/chromium/issues/detail?id=727463 
(most of) win7 tests is
https://bugs.chromium.org/p/chromium/issues/detail?id=727458 
.