win: Set is_clang=true by default.

tools/mb/mb_config.pyl

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is a .pyl, or "Python Literal", file. You can treat it just like a
 # .json file, with the following exceptions:
 # * all keys must be quoted (use single quotes, please);
 # * comments are allowed, using '#' syntax; and
 # * trailing commas are allowed.
 
@@ skipping 119 matching lines @@
         '2': 'official_optimize_chrome_pgo_phase_2',
       },
       'Chromium Windows Analyze': 'windows_analyze',
       'CrWin7Goma': 'release_bot_x86',
       'CrWin7Goma(clbr)': 'shared_release_bot_x86',
       'CrWin7Goma(dbg)': 'debug_bot_x86',
       'CrWin7Goma(dll)': 'shared_release_bot_x86',
 
       # if CrWinClang is modified, please update CrWinClangGoma in the same way.
       'CrWinClang': 'clang_official_release_bot_minimal_symbols_x86',
-
       'CrWinClang(dbg)': 'clang_debug_bot_minimal_symbols_x86',
+      'CrWinClang(shared)': 'clang_minimal_symbols_shared_release_bot_x86',

[brucedawson, 2017/05/17 22:57:17]

How come these two got moved? Alternately, how come the other CrWinClang entries
*didn't* get moved?

[Nico, 2017/05/17 23:01:19]

I was looking through the bot names on
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang (which
has the fyi clang bots with pinned clang). The other CrWinClang (lld) bots
confusingly use trunk clang and should really be called ClangToTWin.

       'CrWinClang64': 'clang_official_release_bot_minimal_symbols',
       'CrWinClang64(dll)': 'clang_shared_release_bot',
+      'CrWinClang64(dbg)': 'win_clang_debug_bot',
       'CrWinClangGoma': 'clang_official_optimize_release_bot_minimal_symbols_x86',
       'CrWinGoma': 'release_bot_x86',
       'CrWinGoma(dll)': 'shared_release_bot_x86',
       'CrWinGoma(loc)': 'shared_release_bot_x86',
       'ClangToTAndroidASan': 'android_clang_tot_asan',
       'ClangToTAndroid (dbg)': 'android_clang_tot_dbg',
       'ClangToTAndroid': 'android_clang_tot_release',
       'ClangToTAndroid64': 'android_clang_tot_release_arm64',
       'ClangToTAndroid x64': 'android_clang_tot_x64',
       'ClangToTLinux': 'clang_tot_linux_full_symbols_shared_release',
       'ClangToTLinux (dbg)': 'clang_tot_shared_debug',
       'ClangToTLinuxASan': 'clang_tot_asan_lsan_static_release',
       'ClangToTLinuxASanLibfuzzer': 'release_libfuzzer_asan_clang_tot',
       'ClangToTLinuxLLD': 'clang_tot_lld_release_shared',
       'ClangToTLinuxUBSanVptr': 'clang_tot_edge_ubsan_no_recover_hack_static_release',
       'ClangToTMac': 'clang_tot_minimal_symbols_shared_release',
       'ClangToTMac (dbg)': 'clang_tot_shared_debug',
       'ClangToTMacASan': 'asan_disable_nacl_clang_tot_full_symbols_static_release',
       'ClangToTWin': 'clang_tot_official_minimal_symbols_static_release_x86',
       'ClangToTWin(dbg)': 'clang_tot_shared_debug_x86',
       'ClangToTWin(dll)': 'clang_tot_minimal_symbols_shared_release_x86',
       'ClangToTWin64': 'clang_tot_official_minimal_symbols_static_release',
       'ClangToTWin64(dbg)': 'clang_tot_shared_debug',
       'ClangToTWin64(dll)': 'clang_tot_shared_release',
       'ClangToTiOS': 'ios',
       'Closure Compilation Linux': 'closure_compilation',
       'CrWinAsan': 'asan_clang_fuzzer_static_v8_heap_x86_full_symbols_release',
       'CrWinAsan(dll)': 'asan_clang_shared_v8_heap_x86_full_symbols_release',
       'CrWinAsanCov': 'asan_clang_edge_fuzzer_static_v8_heap_x86_full_symbols_release',
-      'CrWinClang(shared)': 'clang_minimal_symbols_shared_release_bot_x86',
-      'CrWinClang64(dbg)': 'win_clang_debug_bot',
       'CrWinClangLLD': 'clang_tot_official_static_use_lld_x86',
       'CrWinClangLLD64': 'clang_tot_shared_release_use_lld',
       'CrWinClngLLD64dbg': 'clang_tot_full_symbols_shared_debug_use_lld',
       'CrWinClngLLDdbg': 'clang_tot_full_symbols_shared_debug_use_lld_x86',
       'EarlGreyiOS': 'ios',
       'Fuchsia': 'release_bot_fuchsia',
       'GomaCanaryiOS': 'ios',
       'ios-simulator': 'ios',
       'Headless Linux (dbg)': 'headless_linux_debug_bot',
       'MD Top Chrome ChromeOS material-hybrid': 'chromeos_with_codecs_debug_bot',
@@ skipping 867 matching lines @@
 
     'chromeos_with_codecs_release_trybot': [
       'chromeos_with_codecs', 'x11_cros', 'release_trybot',
     ],
 
     'clang_debug_trybot_x86': [
       'clang', 'debug_trybot', 'x86',
     ],
 
     'clang_debug_bot_minimal_symbols_x86': [
-      'clang', 'debug_bot', 'minimal_symbols', 'x86',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.

[brucedawson, 2017/05/17 22:57:17]

It's not clear which part of this the TODO refers to. I think it is just the
second sentence, so move the TODO to represent that?

[Nico, 2017/05/17 23:01:19]

Done.

+      'no_clang', 'debug_bot', 'minimal_symbols', 'x86',
     ],
 
     'clang_release_bot_minimal_symbols_x86': [
       'clang', 'release_bot', 'minimal_symbols', 'x86',
     ],
 
     'clang_minimal_symbols_shared_release_bot_x86': [
-      'clang', 'minimal_symbols', 'shared_release_bot', 'x86',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'minimal_symbols', 'shared_release_bot', 'x86',
     ],
 
     'clang_official_release_bot_minimal_symbols': [
-      'clang', 'official', 'release_bot', 'minimal_symbols',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'official', 'release_bot', 'minimal_symbols',
     ],
 
     'clang_official_release_bot_minimal_symbols_x86': [
-      'clang', 'official', 'release_bot', 'minimal_symbols', 'x86',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'official', 'release_bot', 'minimal_symbols', 'x86',
     ],
 
     'clang_official_optimize_release_bot_minimal_symbols_x86': [
       'clang', 'official_optimize', 'release_bot', 'minimal_symbols', 'x86',
     ],
 
     'clang_official_release_trybot': [
       'clang', 'official', 'release_trybot',
     ],
 
     'clang_official_release_trybot_x86': [
       'clang', 'official', 'release_trybot', 'x86',
     ],
 
     'clang_shared_release_bot': [
-      'clang', 'shared_release_bot',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'shared_release_bot',
     ],
 
     'clang_tot_asan_lsan_static_release': [
       'clang_tot', 'asan', 'lsan', 'static', 'release',
     ],
 
     'clang_tot_edge_ubsan_no_recover_hack_static_release': [
       'clang_tot', 'edge', 'ubsan_no_recover_hack', 'static', 'release',
     ],
 
@@ skipping 388 matching lines @@
 
     'v8_future_debug_bot': [
       'v8_future', 'debug_bot',
     ],
 
     'v8_future_release_bot': [
       'v8_future', 'release_bot',
     ],
 
     'win_clang_debug_bot': [
-      'clang', 'debug_bot', 'minimal_symbols',
+      # TODO(thakis): Now that the default win bots use clang, use win_clang
+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'debug_bot', 'minimal_symbols',
     ],
 
     'windows_analyze': [
       'no_symbols', 'no_pch', 'shared', 'x86', 'win_analyze',
     ],
   },
 
   # This is a dict mapping a given 'mixin' name to a dict of settings that
   # mb should use. See //tools/mb/docs/user_guide.md for more information.
   'mixins': {
@@ skipping 69 matching lines @@
     'cfi_full': {
       'gn_args': 'use_cfi_cast=true',
       'mixins': ['cfi'],
     },
 
     'cfi_diag': {
       'gn_args': 'use_cfi_diag=true',
     },
 
     'chrome_pgo_phase_1': {
-      'gn_args': 'chrome_pgo_phase=1',
+      'gn_args': 'chrome_pgo_phase=1 is_clang=false',
     },
 
     'chrome_pgo_phase_2': {
-      'gn_args': 'chrome_pgo_phase=2',
+      'gn_args': 'chrome_pgo_phase=2 is_clang=false',
     },
 
     'chrome_with_codecs': {
       'mixins': ['ffmpeg_branding_chrome', 'proprietary_codecs'],
     },
 
     'chromeos': {
       'gn_args': 'target_os="chromeos"',
     },
 
     'chromeos_codecs': {
       'mixins': ['ffmpeg_branding_chromeos', 'proprietary_codecs'],
     },
 
     'chromeos_with_codecs': {
       'mixins': ['chromeos', 'chromeos_codecs'],
     },
 
     'clang_tot': {
       'gn_args': 'llvm_force_head_revision=true clang_use_chrome_plugins=false',
       'mixins': ['clang'],
     },
 
     'clang': {
       'gn_args': 'is_clang=true',
     },
 
+    'no_clang': {
+      'gn_args': 'is_clang=false',
+    },
+
     'cronet': {
       'gn_args': ('disable_file_support=true disable_ftp_support=true '
                   'enable_websockets=false use_platform_icu_alternatives=true '
                   'use_partition_alloc=false'),
     },
 
     'cros_chrome_sdk': {
       # This is used so that the cros chrome_sdk (simplechrome) builders
       # can manage the list of GN args in their .ebuild
       # files and just pass through the desired arguments, hence not
@@ skipping 227 matching lines @@
 
     'static': {
       'gn_args': 'is_component_build=false',
     },
 
     'system_gbm_libdrm': {
       'gn_args': 'use_system_libdrm=true use_system_minigbm=true',
     },
 
     'syzyasan': {
-      'gn_args': 'is_syzyasan=true',
+      # TODO(thakis): Figure out SyzyASan + clang story.
+      'gn_args': 'is_syzyasan=true is_clang=false',
     },
 
     'thin_lto': {
       'gn_args': 'use_thin_lto=true',
       'mixins': ['lto'],
     },
 
     'tsan': {
       'gn_args': 'is_tsan=true',
     },
@@ skipping 36 matching lines @@
 
     'x64': {
       'gn_args': 'target_cpu="x64"',
     },
 
     'x86': {
       'gn_args': 'target_cpu="x86"',
     },
   },
 }