Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2884383004: Roll clang 301384:303273. (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 301384:303273. BUG=714769 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2884383004 . Cr-Commit-Position: refs/heads/master@{#472665} Committed: https://chromium.googlesource.com/chromium/src/+/027325f153ba7f269b197cac9b43cca8519f08bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
hans
Please take a look.
3 years, 7 months ago (2017-05-17 23:51:35 UTC) #10
Nico
lgtm
3 years, 7 months ago (2017-05-18 00:40:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884383004/1
3 years, 7 months ago (2017-05-18 01:45:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884383004/1
3 years, 7 months ago (2017-05-18 03:20:01 UTC) #17
hans
Committed patchset #1 (id:1) manually as 027325f153ba7f269b197cac9b43cca8519f08bf (presubmit successful).
3 years, 7 months ago (2017-05-18 04:35:57 UTC) #19
Marc Treib
3 years, 7 months ago (2017-05-18 11:53:58 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2888363002/ by treib@chromium.org.

The reason for reverting is: Speculative revert: This might have broken
cc_unittests on Linux MSan:
https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests
(In fact, the same tests failed on the linux_chromium_msan_rel_ng right here.)

The failing tests are related to shader transpiling which uses ANGLE which uses
clang. Kind of a long shot, but nothing else looks related..

Powered by Google App Engine
This is Rietveld 408576698