|
|
Created:
3 years, 7 months ago by hans Modified:
3 years, 7 months ago Reviewers:
Nico CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 301384:303273.
BUG=714769
R=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2884383004 .
Cr-Commit-Position: refs/heads/master@{#472665}
Committed: https://chromium.googlesource.com/chromium/src/+/027325f153ba7f269b197cac9b43cca8519f08bf
Patch Set 1 #
Messages
Total messages: 20 (14 generated)
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 301384:303273. Ran `tools/clang/scripts/upload_revision.py 303273`. ========== to ========== Roll clang 301384:303273. Ran `tools/clang/scripts/upload_revision.py 303273`. BUG=714769 ==========
Description was changed from ========== Roll clang 301384:303273. Ran `tools/clang/scripts/upload_revision.py 303273`. BUG=714769 ========== to ========== Roll clang 301384:303273. BUG=714769 ==========
hans@chromium.org changed reviewers: + thakis@chromium.org
Please take a look.
lgtm
The CQ bit was unchecked by hans@chromium.org
The CQ bit was checked by hans@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll clang 301384:303273. BUG=714769 ========== to ========== Roll clang 301384:303273. BUG=714769 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2884383004 . Cr-Commit-Position: refs/heads/master@{#472665} Committed: https://chromium.googlesource.com/chromium/src/+/027325f153ba7f269b197cac9b43... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 027325f153ba7f269b197cac9b43cca8519f08bf (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2888363002/ by treib@chromium.org. The reason for reverting is: Speculative revert: This might have broken cc_unittests on Linux MSan: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests (In fact, the same tests failed on the linux_chromium_msan_rel_ng right here.) The failing tests are related to shader transpiling which uses ANGLE which uses clang. Kind of a long shot, but nothing else looks related.. |