win: Set is_clang=true by default.

tools/mb/mb_config.pyl

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is a .pyl, or "Python Literal", file. You can treat it just like a
 # .json file, with the following exceptions:
 # * all keys must be quoted (use single quotes, please);
 # * comments are allowed, using '#' syntax; and
 # * trailing commas are allowed.
 
@@ skipping 1482 matching lines @@
 
     'v8_future_debug_bot': [
       'v8_future', 'debug_bot',
     ],
 
     'v8_future_release_bot': [
       'v8_future', 'release_bot',
     ],
 
     'win_clang_debug_bot': [
-      'clang', 'debug_bot', 'minimal_symbols',
+      # TODO(thakis): Now that the default win bots uss clang, use win_clang

[hans, 2017/05/15 17:22:43]

s/uss/use/

+      # to make sure things stay compilable with msvc. Having "win_clang"
+      # check that is very confusing, so rename the bot to win_msvc.
+      'no_clang', 'debug_bot', 'minimal_symbols',
     ],
 
     'windows_analyze': [
       'no_symbols', 'no_pch', 'shared', 'x86', 'win_analyze',
     ],
   },
 
   # This is a dict mapping a given 'mixin' name to a dict of settings that
   # mb should use. See //tools/mb/docs/user_guide.md for more information.
   'mixins': {
@@ skipping 69 matching lines @@
     'cfi_full': {
       'gn_args': 'use_cfi_cast=true',
       'mixins': ['cfi'],
     },
 
     'cfi_diag': {
       'gn_args': 'use_cfi_diag=true',
     },
 
     'chrome_pgo_phase_1': {
-      'gn_args': 'chrome_pgo_phase=1',
+      'gn_args': 'chrome_pgo_phase=1 is_clang=false',
     },
 
     'chrome_pgo_phase_2': {
-      'gn_args': 'chrome_pgo_phase=2',
+      'gn_args': 'chrome_pgo_phase=2 is_clang=false',
     },
 
     'chrome_with_codecs': {
       'mixins': ['ffmpeg_branding_chrome', 'proprietary_codecs'],
     },
 
     'chromeos': {
       'gn_args': 'target_os="chromeos"',
     },
 
     'chromeos_codecs': {
       'mixins': ['ffmpeg_branding_chromeos', 'proprietary_codecs'],
     },
 
     'chromeos_with_codecs': {
       'mixins': ['chromeos', 'chromeos_codecs'],
     },
 
     'clang_tot': {
       'gn_args': 'llvm_force_head_revision=true clang_use_chrome_plugins=false',
       'mixins': ['clang'],
     },
 
     'clang': {
       'gn_args': 'is_clang=true',
     },
 
+    'no_clang': {
+      'gn_args': 'is_clang=true',

[Nico, 2017/05/17 22:27:48]

whooooooooops

[hans, 2017/05/17 22:36:45]

But it said no_clang on the tin!

+    },
+
     'cronet': {
       'gn_args': ('disable_file_support=true disable_ftp_support=true '
                   'enable_websockets=false use_platform_icu_alternatives=true '
                   'use_partition_alloc=false'),
     },
 
     'cros_chrome_sdk': {
       # This is used so that the cros chrome_sdk (simplechrome) builders
       # can manage the list of GN args in their .ebuild
       # files and just pass through the desired arguments, hence not
@@ skipping 227 matching lines @@
 
     'static': {
       'gn_args': 'is_component_build=false',
     },
 
     'system_gbm_libdrm': {
       'gn_args': 'use_system_libdrm=true use_system_minigbm=true',
     },
 
     'syzyasan': {
-      'gn_args': 'is_syzyasan=true',
+      # TODO(thakis): Figure out SyzyASan + clang story.
+      'gn_args': 'is_syzyasan=true is_clang=false',
     },
 
     'thin_lto': {
       'gn_args': 'use_thin_lto=true',
       'mixins': ['lto'],
     },
 
     'tsan': {
       'gn_args': 'is_tsan=true',
     },
@@ skipping 36 matching lines @@
 
     'x64': {
       'gn_args': 'target_cpu="x64"',
     },
 
     'x86': {
       'gn_args': 'target_cpu="x86"',
     },
   },
 }