Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2870253003: [ia32] Add rcpps, rsqrtps, cvtdq2ps, cvttps2dq (Closed)

Created:
3 years, 7 months ago by Jing
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer, bbudge
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Add rcpps, rsqrtps, cvtdq2ps, cvttps2dq instr(xmm, xmm/mem) vinstr(xmm, xmm/mem) BUG= Review-Url: https://codereview.chromium.org/2870253003 Cr-Commit-Position: refs/heads/master@{#45293} Committed: https://chromium.googlesource.com/v8/v8/+/1073dc987b57b354134c46d0f9296efc65ec6bec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -16 lines) Patch
M src/ia32/assembler-ia32.h View 4 chunks +37 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 5 chunks +24 lines, -16 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jing
3 years, 7 months ago (2017-05-10 15:56:53 UTC) #2
bbudge
lgtm
3 years, 7 months ago (2017-05-10 18:38:44 UTC) #3
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-10 18:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870253003/1
3 years, 7 months ago (2017-05-15 08:24:03 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 09:00:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1073dc987b57b354134c46d0f9296efc65e...

Powered by Google App Engine
This is Rietveld 408576698