[Home] Add more descriptive user actions for opening/closing the bottom sheet

[Home] Add more descriptive user actions for opening/closing the bottom sheet

This change replaces the Android.ChromeHome.Opened and supplements
the Android.ChromeHome.Closed user actions with four new ones each.
For opening, the new actions are:
- Android.ChromeHome.OpenedBySwipe
- Android.ChromeHome.OpenedByOmnibox
- Android.ChromeHome.OpenedByNTP
- Android.ChromeHome.OpenedByExpandButton

For closing the sheet, the new actions are:
- Android.ChromeHome.ClosedBySwipe
- Android.ChromeHome.ClosedByNTPCloseButton
- Android.ChromeHome.ClosedByTapScrim
- Android.ChromeHome.ClosedByNavigation

BUG=718954
Review-Url: https://codereview.chromium.org/2868553003
Cr-Commit-Position: refs/heads/master@{#470348}
Committed: https://chromium.googlesource.com/chromium/src/+/3420e25cc45f79a2d0da0e2711f9a393de037251

[mdjones, 2017-05-05 21:19:24]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-05-05 21:19:25]

Didn't add a histogram for closed reasons, maybe I should. ptal

[Theresa, 2017-05-05 22:19:37]

lgtm - thank you for adding these!

https://codereview.chromium.org/2868553003/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2868553003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:1137: User closed the Chrome Home bottom sheet
navigating.
nit: bottom sheet by navigating

[mdjones, 2017-05-05 22:40:16]

https://codereview.chromium.org/2868553003/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2868553003/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:1137: User closed the Chrome Home bottom sheet
navigating.
On 2017/05/05 22:19:36, Theresa wrote:
> nit: bottom sheet by navigating

Done.

[mdjones, 2017-05-05 22:41:07]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org, jwd@chromium.org

[mdjones, 2017-05-05 22:41:07]

+jwd for metrics
+dfalcantara for owners

[gone, 2017-05-08 17:12:14]

lgtm

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java
(right):

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java:160:
break;
Typical pattern here is assert false in the default case so you don't miss any.

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java:186:
RecordUserAction.record("Android.ChromeHome.Closed");
Ditto.

[mdjones, 2017-05-08 18:23:45]

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java
(right):

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java:160:
break;
On 2017/05/08 17:12:13, slow (dfalcantara) wrote:
> Typical pattern here is assert false in the default case so you don't miss
any.

Done.

https://codereview.chromium.org/2868553003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java:186:
RecordUserAction.record("Android.ChromeHome.Closed");
On 2017/05/08 17:12:13, slow (dfalcantara) wrote:
> Ditto.

Done.

[jwd, 2017-05-08 22:42:19]

lgtm

[mdjones, 2017-05-08 23:20:20]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-05-08 23:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2868553003/#ps80001
(title: "assert false")

[commit-bot: I haz the power, 2017-05-08 23:35:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:04:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[mdjones, 2017-05-09 15:27:29]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:28:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 16:11:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494343649122680,
"parent_rev": "cac912f19c2acbee95f4ad45f2203481c16baa3d", "commit_rev":
"3420e25cc45f79a2d0da0e2711f9a393de037251"}

[commit-bot: I haz the power, 2017-05-09 16:11:12]

Description was changed from

==========
[Home] Add more descriptive user actions for opening/closing the bottom sheet

This change replaces the Android.ChromeHome.Opened and supplements
the Android.ChromeHome.Closed user actions with four new ones each.
For opening, the new actions are:
- Android.ChromeHome.OpenedBySwipe
- Android.ChromeHome.OpenedByOmnibox
- Android.ChromeHome.OpenedByNTP
- Android.ChromeHome.OpenedByExpandButton

For closing the sheet, the new actions are:
- Android.ChromeHome.ClosedBySwipe
- Android.ChromeHome.ClosedByNTPCloseButton
- Android.ChromeHome.ClosedByTapScrim
- Android.ChromeHome.ClosedByNavigation

BUG=718954
==========

to

==========
[Home] Add more descriptive user actions for opening/closing the bottom sheet

This change replaces the Android.ChromeHome.Opened and supplements
the Android.ChromeHome.Closed user actions with four new ones each.
For opening, the new actions are:
- Android.ChromeHome.OpenedBySwipe
- Android.ChromeHome.OpenedByOmnibox
- Android.ChromeHome.OpenedByNTP
- Android.ChromeHome.OpenedByExpandButton

For closing the sheet, the new actions are:
- Android.ChromeHome.ClosedBySwipe
- Android.ChromeHome.ClosedByNTPCloseButton
- Android.ChromeHome.ClosedByTapScrim
- Android.ChromeHome.ClosedByNavigation

BUG=718954

Review-Url: https://codereview.chromium.org/2868553003
Cr-Commit-Position: refs/heads/master@{#470348}
Committed:
https://chromium.googlesource.com/chromium/src/+/3420e25cc45f79a2d0da0e2711f9...
==========

[commit-bot: I haz the power, 2017-05-09 16:11:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3420e25cc45f79a2d0da0e2711f9...