Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Issue 2868553003: [Home] Add more descriptive user actions for opening/closing the bottom sheet (Closed)
Patch Set: assert false Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
index 48602af38b47d2ece5e6084edd9c66138dda557a..d8455e404d640ab50899f55da78dffeb0b9d4262 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
@@ -342,6 +342,9 @@ public class BottomSheet
@SheetState
int targetState = getTargetSheetState(
getSheetOffsetFromBottom() + getFlingDistance(-velocityY), -velocityY);
+ if (targetState == SHEET_STATE_PEEK) {
+ mMetrics.setSheetCloseReason(BottomSheetMetrics.CLOSED_BY_SWIPE);
+ }
setSheetState(targetState, true);
mIsScrolling = false;
@@ -437,6 +440,9 @@ public class BottomSheet
@SheetState
int targetState = getTargetSheetState(getSheetOffsetFromBottom(), currentVelocity);
+ if (targetState == SHEET_STATE_PEEK) {
+ mMetrics.setSheetCloseReason(BottomSheetMetrics.CLOSED_BY_SWIPE);
+ }
setSheetState(targetState, true);
}
}
@@ -605,6 +611,7 @@ public class BottomSheet
}
// In all non-native cases, minimize the sheet.
+ mMetrics.setSheetCloseReason(BottomSheetMetrics.CLOSED_BY_NAVIGATION);
setSheetState(SHEET_STATE_PEEK, true);
assert mTabModelSelector != null;
@@ -1140,6 +1147,7 @@ public class BottomSheet
@Override
public void onFadingViewClick() {
+ mMetrics.setSheetCloseReason(BottomSheetMetrics.CLOSED_BY_TAP_SCRIM);
setSheetState(SHEET_STATE_PEEK, true);
}

Powered by Google App Engine
This is Rietveld 408576698