chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java - Issue 2868553003: [Home] Add more descriptive user actions for opening/closing the bottom sheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

Issue 2868553003: [Home] Add more descriptive user actions for opening/closing the bottom sheet (Closed)

Patch Set: assert false Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

index 1f42cf90bacdf7f6c0743f6e55e4075d2bdb77fc..14c0d543dcfc600139c1e673531529667c6b9811 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java

@@ -96,6 +96,8 @@ public abstract class ChromeHomeNewTabPageBase implements NativePage {

// If the NTP is loading, the sheet state will be set to SHEET_STATE_HALF.

if (TextUtils.equals(tab.getUrl(), getUrl())) return;

+ mBottomSheet.getBottomSheetMetrics().setSheetCloseReason(

+ BottomSheetMetrics.CLOSED_BY_NAVIGATION);

mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true);

}

};

@@ -174,6 +176,8 @@ public abstract class ChromeHomeNewTabPageBase implements NativePage {

mCloseButton.setOnClickListener(new OnClickListener() {

@Override

public void onClick(View v) {

+ mBottomSheet.getBottomSheetMetrics().setSheetCloseReason(

+ BottomSheetMetrics.CLOSED_BY_NTP_CLOSE_BUTTON);

mBottomSheet.setSheetState(BottomSheet.SHEET_STATE_PEEK, true);

if (mShowOverviewOnClose && getLayoutManager() != null) {

getLayoutManager().showOverview(false);