Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2868553003: [Home] Add more descriptive user actions for opening/closing the bottom sheet (Closed)
Patch Set: assert false Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 332cda5e8d6b6dc446768d5164cf8739b0334d4f..dd731dbb3df9b81eae2e0234e24d893746f70a9b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -117,6 +117,7 @@ import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.util.IntentUtils;
import org.chromium.chrome.browser.vr_shell.VrShellDelegate;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
+import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetMetrics;
import org.chromium.chrome.browser.widget.emptybackground.EmptyBackgroundViewWrapper;
import org.chromium.chrome.browser.widget.findinpage.FindToolbarManager;
import org.chromium.chrome.browser.widget.textbubble.ViewAnchoredTextBubble;
@@ -985,6 +986,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (getBottomSheet() != null) {
// Either a new tab is opening, a tab is being clobbered, or a tab is being brought
// to the front. In all scenarios, the bottom sheet should be closed.
+ getBottomSheet().getBottomSheetMetrics().setSheetCloseReason(
+ BottomSheetMetrics.CLOSED_BY_NAVIGATION);
getBottomSheet().setSheetState(BottomSheet.SHEET_STATE_PEEK, true);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPageBase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698