[inspector] use creation stack trace as parent for async call chains

[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained, scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Original-Commit-Position: refs/heads/master@{#45198}
Committed: https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997cbfc5a
Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45266}
Committed: https://chromium.googlesource.com/v8/v8/+/f61facfdaf4f0fb9c7fcdee8b1425f28cc67b647

[kozy, 2017-05-05 18:55:40]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 18:55:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:32:51]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-05-05 19:35:40]

Dmitry, please take a look.

[kozy, 2017-05-05 20:34:02]

Description was changed from

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same stack.

BUG=v8:6189
R=dgozman@chromium.org
==========

to

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org
==========

[dgozman, 2017-05-05 23:24:31]

lgtm

https://codereview.chromium.org/2868493002/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2868493002/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:942: m_currentAsyncParent.back()->description());
Also clear m_currentAsyncParent.back().

[kozy, 2017-05-09 06:29:13]

all done.

https://codereview.chromium.org/2868493002/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2868493002/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:942: m_currentAsyncParent.back()->description());
On 2017/05/05 23:24:31, dgozman wrote:
> Also clear m_currentAsyncParent.back().

Done.

[kozy, 2017-05-09 06:29:20]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 06:29:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 08:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 08:21:52]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-05-09 14:41:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-05-09 14:41:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2868493002/#ps20001
(title: "ac")

[commit-bot: I haz the power, 2017-05-09 14:41:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 14:43:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494340888504100,
"parent_rev": "d8bfdb7a998adadc56aa5705a5998e75ceae7675", "commit_rev":
"e118462f18a862df81a04486e13dd62997cbfc5a"}

[commit-bot: I haz the power, 2017-05-09 14:43:21]

Description was changed from

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org
==========

to

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45198}
Committed:
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...
==========

[commit-bot: I haz the power, 2017-05-09 14:43:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...

[alex clarke (OOO till 29th), 2017-05-10 20:28:05]

alexclarke@chromium.org changed reviewers:
+ alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-05-10 20:28:06]

This patch is causing lots of test failures on the waterfall, please revert:

E.g.
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[kozy, 2017-05-10 20:43:17]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2868423004/ by kozyatinskiy@chromium.org.

The reason for reverting is: CHECK is too strict..

[kozy, 2017-05-10 20:46:38]

On 2017/05/10 20:28:06, alex clarke wrote:
> This patch is causing lots of test failures on the waterfall, please revert:
> 
> E.g.
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

reverting and will roll V8 with revert soon.

[kozy, 2017-05-10 21:26:18]

Description was changed from

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45198}
Committed:
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...
==========

to

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45198}
Committed:
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...
==========

[kozy, 2017-05-10 21:43:50]

Since blink has own instrumentation for blink wrapper around promises we can't
have DCHECK here before:
https://codereview.chromium.org/2872723002/ is landed.

[kozy, 2017-05-11 18:48:25]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-05-11 18:48:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2868493002/#ps40001
(title: "removed DCHECK for now")

[commit-bot: I haz the power, 2017-05-11 18:48:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:21:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494528505302780,
"parent_rev": "28f3bf1a2727489c0227cdb8c111b6ffa2c71189", "commit_rev":
"f61facfdaf4f0fb9c7fcdee8b1425f28cc67b647"}

[commit-bot: I haz the power, 2017-05-11 19:21:33]

Description was changed from

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45198}
Committed:
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...
==========

to

==========
[inspector] use creation stack trace as parent for async call chains

Creation stack trace points to the place where callback was actually chained,
scheduled points where parent promise was resolved.
For async tasks without creation stack (e.g. setTimeout) we continue to use
scheduled as creation since usually they are the same.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2868493002
Cr-Original-Commit-Position: refs/heads/master@{#45198}
Committed:
https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997c...
Review-Url: https://codereview.chromium.org/2868493002
Cr-Commit-Position: refs/heads/master@{#45266}
Committed:
https://chromium.googlesource.com/v8/v8/+/f61facfdaf4f0fb9c7fcdee8b1425f28cc6...
==========

[commit-bot: I haz the power, 2017-05-11 19:21:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/f61facfdaf4f0fb9c7fcdee8b1425f28cc6...