Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: src/inspector/v8-stack-trace-impl.cc

Issue 2868493002: [inspector] use creation stack trace as parent for async call chains (Closed)
Patch Set: removed DCHECK for now Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-stack-trace-impl.h ('k') | test/inspector/debugger/async-for-await-of-promise-stack.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-stack-trace-impl.cc
diff --git a/src/inspector/v8-stack-trace-impl.cc b/src/inspector/v8-stack-trace-impl.cc
index cb509bd8e9d67614aa3a8429f2b1500eff407ed5..a2a4ce1b6eb8dfae18cacff6a556b0a66754c9d3 100644
--- a/src/inspector/v8-stack-trace-impl.cc
+++ b/src/inspector/v8-stack-trace-impl.cc
@@ -298,14 +298,9 @@ AsyncStackTrace::AsyncStackTrace(
std::unique_ptr<protocol::Runtime::StackTrace>
AsyncStackTrace::buildInspectorObject(AsyncStackTrace* asyncCreation,
int maxAsyncDepth) const {
- std::unique_ptr<protocol::Runtime::StackTrace> stackTrace =
- buildInspectorObjectCommon(m_frames, m_description, m_asyncParent.lock(),
- m_asyncCreation.lock(), maxAsyncDepth);
- if (asyncCreation && !asyncCreation->isEmpty()) {
- stackTrace->setPromiseCreationFrame(
- asyncCreation->m_frames[0]->buildInspectorObject());
- }
- return stackTrace;
+ return buildInspectorObjectCommon(m_frames, m_description,
+ m_asyncParent.lock(),
+ m_asyncCreation.lock(), maxAsyncDepth);
}
int AsyncStackTrace::contextGroupId() const { return m_contextGroupId; }
« no previous file with comments | « src/inspector/v8-stack-trace-impl.h ('k') | test/inspector/debugger/async-for-await-of-promise-stack.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698