Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2872723002: [DevTools] removed promise instrumentation from blink

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] removed promise instrumentation from blink Since our new stacks using asyncTaskCreation we don't need blink instrumentation. asyncTaskCreated will be called as part of promise constructor and corresponded .then call. Later we add meaningful description for asyncTaskCreation which will replace Async Call with something more specific. BUG=v8:6189 R=dgozman@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-fetch-expected.txt View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 4 chunks +0 lines, -4 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 6 (3 generated)
kozy
Dmitry, please take a look.
3 years, 7 months ago (2017-05-08 20:11:32 UTC) #3
dgozman
Let's wait a bit with landing this, until we are sure about new stacks. https://codereview.chromium.org/2872723002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-fetch-expected.txt ...
3 years, 7 months ago (2017-05-08 23:28:05 UTC) #5
dgozman
3 years, 5 months ago (2017-07-15 05:52:54 UTC) #6
I think we are pretty confident in new stacks. Should we continue this?

Powered by Google App Engine
This is Rietveld 408576698