Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2868423004: Revert of [inspector] use creation stack trace as parent for async call chains (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] use creation stack trace as parent for async call chains (patchset #2 id:20001 of https://codereview.chromium.org/2868493002/ ) Reason for revert: CHECK is too strict. Original issue's description: > [inspector] use creation stack trace as parent for async call chains > > Creation stack trace points to the place where callback was actually chained, scheduled points where parent promise was resolved. > For async tasks without creation stack (e.g. setTimeout) we continue to use scheduled as creation since usually they are the same. > > BUG=v8:6189 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2868493002 > Cr-Commit-Position: refs/heads/master@{#45198} > Committed: https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997cbfc5a TBR=dgozman@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:6189 Review-Url: https://codereview.chromium.org/2868423004 Cr-Commit-Position: refs/heads/master@{#45242} Committed: https://chromium.googlesource.com/v8/v8/+/fe0d5c7ca80181d7a581de9cbcdc26a6b2a40b7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+626 lines, -494 lines) Patch
M src/inspector/v8-debugger.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M test/inspector/debugger/async-for-await-of-promise-stack.js View 6 chunks +6 lines, -6 lines 0 comments Download
M test/inspector/debugger/async-for-await-of-promise-stack-expected.txt View 1 chunk +26 lines, -27 lines 0 comments Download
M test/inspector/debugger/async-instrumentation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/debugger/async-promise-late-then-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/inspector/debugger/async-stack-await-expected.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M test/inspector/debugger/async-stack-created-frame.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector/debugger/async-stack-created-frame-expected.txt View 1 chunk +33 lines, -24 lines 0 comments Download
M test/inspector/debugger/async-stack-for-promise-expected.txt View 1 chunk +92 lines, -37 lines 0 comments Download
M test/inspector/debugger/collect-old-async-call-chains-expected.txt View 5 chunks +136 lines, -136 lines 0 comments Download
M test/inspector/debugger/max-async-call-chain-depth.js View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/max-async-call-chain-depth-expected.txt View 2 chunks +42 lines, -23 lines 0 comments Download
M test/inspector/debugger/promise-chain-when-limit-hit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/promise-chain-when-limit-hit-expected.txt View 1 chunk +259 lines, -196 lines 0 comments Download
M test/inspector/debugger/set-async-call-stack-depth.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/inspector/debugger/set-async-call-stack-depth-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kozy
Created Revert of [inspector] use creation stack trace as parent for async call chains
3 years, 7 months ago (2017-05-10 20:43:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868423004/1
3 years, 7 months ago (2017-05-10 20:43:21 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:24:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fe0d5c7ca80181d7a581de9cbcdc26a6b2a...

Powered by Google App Engine
This is Rietveld 408576698