Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2868283003: [SPv2] Renaming and refactor about raster invalidation tracking (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Renaming and refactor about raster invalidation tracking - Shorten names by removing redundant qualifiers. - Separate the code path for tracking to improve performance of the normal path. BUG=644358 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2868283003 Cr-Commit-Position: refs/heads/master@{#471207} Committed: https://chromium.googlesource.com/chromium/src/+/ac1414588aedb11ae6a11223c7c3cca1057a4773

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -155 lines) Patch
M third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp View 1 6 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp View 1 21 chunks +21 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 5 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 6 chunks +20 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 3 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 12 chunks +32 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/RasterInvalidationTracking.h View 1 2 3 6 chunks +18 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/RasterInvalidationTracking.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
Xianzhu
3 years, 7 months ago (2017-05-11 17:39:40 UTC) #12
chrishtr
lgtm
3 years, 7 months ago (2017-05-11 22:58:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868283003/60001
3 years, 7 months ago (2017-05-11 22:59:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/368795)
3 years, 7 months ago (2017-05-12 00:25:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868283003/60001
3 years, 7 months ago (2017-05-12 01:14:41 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 03:26:24 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ac1414588aedb11ae6a11223c7c3...

Powered by Google App Engine
This is Rietveld 408576698