Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2876923002: Track client debug names for raster invalidation tracking (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Track client debug names for raster invalidation tracking This reduces differences of layout test results of spv2, and also makes spv2 paint invalidation output more meaningful. BUG=644358 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2876923002 Cr-Commit-Position: refs/heads/master@{#471322} Committed: https://chromium.googlesource.com/chromium/src/+/0a9d3c58e9032f9866e171da02bafe9592f76552

Patch Set 1 #

Patch Set 2 : Use MakeUnique #

Patch Set 3 : - #

Patch Set 4 : Rebaseline virtual/spv2/paint/invalidation/margin.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 9 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/spv2/paint/invalidation/margin-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 3 chunks +13 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 10 chunks +53 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (22 generated)
Xianzhu
3 years, 7 months ago (2017-05-11 22:50:29 UTC) #6
chrishtr
lgtm
3 years, 7 months ago (2017-05-11 23:02:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876923002/40001
3 years, 7 months ago (2017-05-12 04:14:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876923002/60001
3 years, 7 months ago (2017-05-12 04:45:44 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/382775)
3 years, 7 months ago (2017-05-12 06:01:07 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876923002/60001
3 years, 7 months ago (2017-05-12 15:37:12 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:07:06 UTC) #29
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0a9d3c58e9032f9866e171da02ba...

Powered by Google App Engine
This is Rietveld 408576698