Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2874553002: [SPv2] Fix layout test crashes about raster invalidation (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Fix layout test crashes about raster invalidation 1. FrameView::SetTracksPaintInvalidations() may be called before FrameView::PrePaint(), so we need to create paint_controller_ if it is null, and check null paint_artifact_compositor_. 2. Previously when an old chunk is deleted, we still kept the tracked raster invalidations. When a new chunk was created at the same address, the new chunk inherited the old trackings. BUG=644358 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2874553002 . Cr-Commit-Position: refs/heads/master@{#470997} Committed: https://chromium.googlesource.com/chromium/src/+/536ac1bf9b09f54680b6f97b8a8a020026413517

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Total comments: 4

Patch Set 4 : Reduce #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 3 4 4 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Xianzhu
3 years, 7 months ago (2017-05-09 22:45:47 UTC) #4
chrishtr
https://codereview.chromium.org/2874553002/diff/40001/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (left): https://codereview.chromium.org/2874553002/diff/40001/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp#oldcode519 third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:519: if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) { No longer needed? https://codereview.chromium.org/2874553002/diff/40001/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp File third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp ...
3 years, 7 months ago (2017-05-10 17:25:33 UTC) #6
Xianzhu
Uploaded a new patch just fixing the crashes. Ptal. Will create another patch for renaming ...
3 years, 7 months ago (2017-05-10 18:27:02 UTC) #8
chrishtr
lgtm
3 years, 7 months ago (2017-05-11 15:04:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874553002/80001
3 years, 7 months ago (2017-05-11 15:49:01 UTC) #15
Xianzhu
3 years, 7 months ago (2017-05-11 17:32:52 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
536ac1bf9b09f54680b6f97b8a8a020026413517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698