Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2868283003: [SPv2] Renaming and refactor about raster invalidation tracking (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 10929 matching lines...) Expand 10 before | Expand all | Expand 10 after
10940 EXPECT_EQ(kViewportHeight, 10940 EXPECT_EQ(kViewportHeight,
10941 compositor->RootLayer()->GraphicsLayerBacking()->Size().Height()); 10941 compositor->RootLayer()->GraphicsLayerBacking()->Size().Height());
10942 EXPECT_EQ(kViewportHeight, compositor->RootGraphicsLayer()->Size().Height()); 10942 EXPECT_EQ(kViewportHeight, compositor->RootGraphicsLayer()->Size().Height());
10943 10943
10944 const RasterInvalidationTracking* invalidation_tracking = 10944 const RasterInvalidationTracking* invalidation_tracking =
10945 document->GetLayoutView() 10945 document->GetLayoutView()
10946 ->Layer() 10946 ->Layer()
10947 ->GraphicsLayerBacking() 10947 ->GraphicsLayerBacking()
10948 ->GetRasterInvalidationTracking(); 10948 ->GetRasterInvalidationTracking();
10949 ASSERT_TRUE(invalidation_tracking); 10949 ASSERT_TRUE(invalidation_tracking);
10950 const auto* raster_invalidations = 10950 const auto* raster_invalidations = &invalidation_tracking->invalidations;
10951 &invalidation_tracking->tracked_raster_invalidations;
10952 10951
10953 // The newly revealed content at the bottom of the screen should have been 10952 // The newly revealed content at the bottom of the screen should have been
10954 // invalidated. There are additional invalidations for the position: fixed 10953 // invalidated. There are additional invalidations for the position: fixed
10955 // element. 10954 // element.
10956 EXPECT_GT(raster_invalidations->size(), 0u); 10955 EXPECT_GT(raster_invalidations->size(), 0u);
10957 EXPECT_TRUE((*raster_invalidations)[0].rect.Contains( 10956 EXPECT_TRUE((*raster_invalidations)[0].rect.Contains(
10958 IntRect(0, kViewportHeight - kBrowserControlsHeight, kViewportWidth, 10957 IntRect(0, kViewportHeight - kBrowserControlsHeight, kViewportWidth,
10959 kBrowserControlsHeight))); 10958 kBrowserControlsHeight)));
10960 10959
10961 document->View()->SetTracksPaintInvalidations(false); 10960 document->View()->SetTracksPaintInvalidations(false);
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
12043 12042
12044 // Failing the original child frame navigation and trying to render fallback 12043 // Failing the original child frame navigation and trying to render fallback
12045 // content shouldn't crash. It should return NoLoadInProgress. This is so the 12044 // content shouldn't crash. It should return NoLoadInProgress. This is so the
12046 // caller won't attempt to replace the correctly empty frame with an error 12045 // caller won't attempt to replace the correctly empty frame with an error
12047 // page. 12046 // page.
12048 EXPECT_EQ(WebLocalFrame::NoLoadInProgress, 12047 EXPECT_EQ(WebLocalFrame::NoLoadInProgress,
12049 child->MaybeRenderFallbackContent(WebURLError())); 12048 child->MaybeRenderFallbackContent(WebURLError()));
12050 } 12049 }
12051 12050
12052 } // namespace blink 12051 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698