[Devtools] Added report miss-match link to network product entries

[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/XE7ma (if clicked within devtools should be auto-filled)

R=pfeldman,dgozman
BUG=719715
Review-Url: https://codereview.chromium.org/2867713006
Cr-Commit-Position: refs/heads/master@{#470834}
Committed: https://chromium.googlesource.com/chromium/src/+/e8f057c474108daa91ebd9c594b0ad1bb0a117e5

[allada, 2017-05-08 21:52:55]

Description was changed from

==========
[Devtools] Added report missmatch to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0

R=pfeldman,dgozman
BUG=719715
==========

to

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0

R=pfeldman,dgozman
BUG=719715
==========

[allada, 2017-05-08 22:39:49]

Patchset #1 (id:1) has been deleted

[allada, 2017-05-08 22:39:54]

Patchset #1 (id:20001) has been deleted

[allada, 2017-05-08 22:41:32]

PTL - I am thinking we should make ProductRegistry.Registry.ProductEntry's
attributes (name, type, exc...) be proper function getter/setters instead of
exposing the variables directly, however it will be a little more of a pain for
console changes and timeline already is a consumer.

[allada, 2017-05-08 22:43:24]

Description was changed from

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0

R=pfeldman,dgozman
BUG=719715
==========

to

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/hTJMi (if clicked within devtools should be
auto-filled)

R=pfeldman,dgozman
BUG=719715
==========

[allada, 2017-05-09 00:58:01]

Description was changed from

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/hTJMi (if clicked within devtools should be
auto-filled)

R=pfeldman,dgozman
BUG=719715
==========

to

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/XE7ma (if clicked within devtools should be
auto-filled)

R=pfeldman,dgozman
BUG=719715
==========

[allada, 2017-05-09 01:03:42]

PTaL - findCreationCallFrame() is a perfect case for generators, but the
cleanest code was to either have a search function callback or to have it return
a straight array of entries. I ended up doing a callback because I really did
not like the restrictions and overhead of returning an array would impose.

[pfeldman, 2017-05-09 17:54:51]

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:53:
UI.appendStyle(content, 'network/networkReportProductEntry.css');
You should create local shadow root, otherwise your css applies to the whole
document.

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:90:
static productEntryInfoForFrame(productRegistry, frame) {
Move this to ResourceTreeFrame?

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css:10:
.network-product-popover .network-product-domain {
I was hoping we had enough stlyes in inspectorCommon for this kind of UI.

[allada, 2017-05-09 20:40:22]

PTaL

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:53:
UI.appendStyle(content, 'network/networkReportProductEntry.css');
On 2017/05/09 17:54:51, pfeldman wrote:
> You should create local shadow root, otherwise your css applies to the whole
> document.

Done.

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:90:
static productEntryInfoForFrame(productRegistry, frame) {
On 2017/05/09 17:54:50, pfeldman wrote:
> Move this to ResourceTreeFrame?

I would rather not have SDK depends on ProductRegistry. I feel introducing a
"findCreationCallFrame" or something similar is good enough... Even for joel's
patch we cannot use this same logic because his patch does not use the same
logic.

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css:10:
.network-product-popover .network-product-domain {
On 2017/05/09 17:54:51, pfeldman wrote:
> I was hoping we had enough stlyes in inspectorCommon for this kind of UI.

The closest thing we have is gray-info-message, which still requires a bit of
more work to make it look good.

[allada, 2017-05-09 20:40:22]

PTaL

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:53:
UI.appendStyle(content, 'network/networkReportProductEntry.css');
On 2017/05/09 17:54:51, pfeldman wrote:
> You should create local shadow root, otherwise your css applies to the whole
> document.

Done.

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:90:
static productEntryInfoForFrame(productRegistry, frame) {
On 2017/05/09 17:54:50, pfeldman wrote:
> Move this to ResourceTreeFrame?

I would rather not have SDK depends on ProductRegistry. I feel introducing a
"findCreationCallFrame" or something similar is good enough... Even for joel's
patch we cannot use this same logic because his patch does not use the same
logic.

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/networkReportProductEntry.css:10:
.network-product-popover .network-product-domain {
On 2017/05/09 17:54:51, pfeldman wrote:
> I was hoping we had enough stlyes in inspectorCommon for this kind of UI.

The closest thing we have is gray-info-message, which still requires a bit of
more work to make it look good.

[pfeldman, 2017-05-10 20:52:00]

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2867713006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:90:
static productEntryInfoForFrame(productRegistry, frame) {
On 2017/05/09 20:40:22, allada wrote:
> On 2017/05/09 17:54:50, pfeldman wrote:
> > Move this to ResourceTreeFrame?
> 
> I would rather not have SDK depends on ProductRegistry. I feel introducing a
> "findCreationCallFrame" or something similar is good enough... Even for joel's
> patch we cannot use this same logic because his patch does not use the same
> logic.

I meant the part that returns URL.

[pfeldman, 2017-05-10 22:36:19]

lgtm

[allada, 2017-05-10 22:36:55]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:37:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:12:47]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[allada, 2017-05-10 23:22:56]

The CQ bit was checked by allada@chromium.org

[allada, 2017-05-10 23:22:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2867713006/#ps100001
(title: "changes")

[allada, 2017-05-10 23:34:34]

The CQ bit was checked by allada@chromium.org

[allada, 2017-05-10 23:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2867713006/#ps100001
(title: "changes")

[commit-bot: I haz the power, 2017-05-10 23:35:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:53:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[allada, 2017-05-11 04:13:38]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:14:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494476018753370,
"parent_rev": "6d44fde7f95c979cd78698142389b6fe4fa8916f", "commit_rev":
"e8f057c474108daa91ebd9c594b0ad1bb0a117e5"}

[commit-bot: I haz the power, 2017-05-11 05:58:27]

Description was changed from

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/XE7ma (if clicked within devtools should be
auto-filled)

R=pfeldman,dgozman
BUG=719715
==========

to

==========
[Devtools] Added report miss-match to network product entries

Added the ability to report bad attribution to product registry.
Currently only exposed in network panel.

See: http://imgur.com/a/NJkq0
Form screenshot: http://imgur.com/a/XE7ma (if clicked within devtools should be
auto-filled)

R=pfeldman,dgozman
BUG=719715

Review-Url: https://codereview.chromium.org/2867713006
Cr-Commit-Position: refs/heads/master@{#470834}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8f057c474108daa91ebd9c594b0...
==========

[commit-bot: I haz the power, 2017-05-11 05:58:28]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e8f057c474108daa91ebd9c594b0...