Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2867713006: [Devtools] Added report miss-match link to network product entries (Closed)
Patch Set: changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 96d19c5a06aa5093b92feb47d449831d27d95f51..d1fab849ab28dfbf7166d9dfe1003d1171dd5802 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -102,6 +102,7 @@ Network.NetworkLogViewColumns = class {
this._popoverHelper = new UI.PopoverHelper(this._networkLogView.element, this._getPopoverRequest.bind(this));
this._popoverHelper.setHasPadding(true);
+ this._popoverHelper.setTimeout(300, 300);
/** @type {!DataGrid.SortableDataGrid<!Network.NetworkNode>} */
this._dataGrid =
@@ -549,13 +550,26 @@ Network.NetworkLogViewColumns = class {
_getPopoverRequest(event) {
if (!this._gridMode)
return null;
+ var hoveredNode = this._networkLogView.hoveredNode();
+ if (!hoveredNode)
+ return null;
+
+ var anchor = event.target.enclosingNodeOrSelfWithClass('product-column');
+ if (anchor) {
+ return {
+ box: anchor.boxInWindow(),
+ show: hoveredNode.handleProductPopover.bind(hoveredNode),
+ hide: this._popupLinkifier.reset.bind(this._popupLinkifier)
+ };
+ }
- var anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initiated');
- var request = /** @type {?SDK.NetworkRequest} */ (anchor ? anchor.request : null);
+ anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initiated');
+ if (!anchor)
+ return null;
+ var request = hoveredNode.request();
var initiator = request ? request.initiator() : null;
if (!initiator || !initiator.stack)
return null;
-
return {
box: anchor.boxInWindow(),
show: popover => {
@@ -564,9 +578,7 @@ Network.NetworkLogViewColumns = class {
popover.contentElement.appendChild(content);
return Promise.resolve(true);
},
- hide: () => {
- this._popupLinkifier.reset();
- }
+ hide: this._popupLinkifier.reset.bind(this._popupLinkifier)
};
}

Powered by Google App Engine
This is Rietveld 408576698