Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2869233002: [Devtools] Added product registry domain pattern test

Created:
3 years, 7 months ago by allada
Modified:
3 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added product registry domain pattern test Added test for product registry to ensure that domains give consistant results. R=dgozman,pfeldman BUG=720133

Patch Set 1 #

Patch Set 2 : [Devtools] Added product registry domain pattern test #

Total comments: 2

Patch Set 3 : changes #

Patch Set 4 : changes #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Messages

Total messages: 18 (12 generated)
allada
PTL
3 years, 7 months ago (2017-05-09 22:35:15 UTC) #1
pfeldman
https://codereview.chromium.org/2869233002/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js File third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js (right): https://codereview.chromium.org/2869233002/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js#newcode95 third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js:95: ProductRegistryImpl.registerEntryForTest = function(domainPattern, productName, type) { This code should ...
3 years, 7 months ago (2017-05-10 20:51:19 UTC) #2
allada
PTaL https://codereview.chromium.org/2869233002/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js File third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js (right): https://codereview.chromium.org/2869233002/diff/20001/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js#newcode95 third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js:95: ProductRegistryImpl.registerEntryForTest = function(domainPattern, productName, type) { On 2017/05/10 ...
3 years, 7 months ago (2017-05-10 23:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869233002/100001
3 years, 7 months ago (2017-05-12 18:42:03 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-12 18:42:06 UTC) #11
pfeldman
3 years, 5 months ago (2017-07-19 05:44:35 UTC) #18
lgtm - i have no memory of this

Powered by Google App Engine
This is Rietveld 408576698