Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js

Issue 2867713006: [Devtools] Added report miss-match link to network product entries (Closed)
Patch Set: changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js
diff --git a/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js b/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js
index 977720e5940c056a8954e3260af210c7a2dfcba5..f693daf0e309d2772010e66dd7eafd60daf63555 100644
--- a/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js
+++ b/third_party/WebKit/Source/devtools/front_end/product_registry_impl/ProductRegistryImpl.js
@@ -73,47 +73,8 @@ ProductRegistryImpl.Registry = class {
return entry.type;
return null;
}
-
- /**
- * @override
- * @param {!SDK.ResourceTreeFrame} frame
- * @return {?ProductRegistry.Registry.ProductEntry}
- */
- entryForFrame(frame) {
- var entry;
- if (frame.url)
- entry = this.entryForUrl(new Common.ParsedURL(frame.url));
- if (entry)
- return entry;
- // We are not caching the frame url result because it may change.
- var symbol = ProductRegistryImpl.Registry._productEntryForFrameSymbol;
- if (!(symbol in frame))
- frame[symbol] = this._lookupStackTraceEntryForFrame(frame);
- return frame[symbol];
- }
-
- /**
- * @param {!SDK.ResourceTreeFrame} frame
- * @return {?ProductRegistry.Registry.ProductEntry}
- */
- _lookupStackTraceEntryForFrame(frame) {
- var stackTrace = frame.creationStackTrace();
- var entry;
- while (stackTrace) {
- for (var stack of stackTrace.callFrames) {
- if (stack.url)
- entry = this.entryForUrl(new Common.ParsedURL(stack.url));
- if (entry)
- return entry;
- }
- stackTrace = frame.parent;
- }
- return null;
- }
};
-ProductRegistryImpl.Registry._productEntryForFrameSymbol = Symbol('ProductEntryForFrame');
-
/**
* @param {string} domain
* @return {string}

Powered by Google App Engine
This is Rietveld 408576698