Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2867033002: Fix BrowsingDataCounter race condition (Closed)

Created:
3 years, 7 months ago by dullweber
Modified:
3 years, 7 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BrowsingDataCounter race condition There is a chance that a BrowsingDataCounter is still counting when it is restarted. To avoid calling ReportResult twice and hitting a NOTREACHED() all asynchronous tasks have to be cancelled when Count() is called. BUG=719376 Review-Url: https://codereview.chromium.org/2867033002 Cr-Commit-Position: refs/heads/master@{#469956} Committed: https://chromium.googlesource.com/chromium/src/+/a34462a6f8d57df524dd8cb17e61b094dedee879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/browsing_data/cache_counter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/media_licenses_counter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/site_data_counter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/browsing_data/core/counters/browsing_data_counter.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/browsing_data/core/counters/history_counter.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dullweber
Hi Martin, these should be all the counters with an asynchronous response.
3 years, 7 months ago (2017-05-08 09:44:07 UTC) #4
msramek
LGTM, thanks!
3 years, 7 months ago (2017-05-08 09:59:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867033002/1
3 years, 7 months ago (2017-05-08 10:46:06 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:49:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a34462a6f8d57df524dd8cb17e61...

Powered by Google App Engine
This is Rietveld 408576698