chrome/browser/browsing_data/cache_counter.cc - Issue 2867033002: Fix BrowsingDataCounter race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/cache_counter.cc

Issue 2867033002: Fix BrowsingDataCounter race condition (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/cache_counter.cc

diff --git a/chrome/browser/browsing_data/cache_counter.cc b/chrome/browser/browsing_data/cache_counter.cc

index 557be8a39e14d9b52d2036af2657d79b13c30017..d131033608d252204bd70105a4bd5a213afe24b4 100644

--- a/chrome/browser/browsing_data/cache_counter.cc

+++ b/chrome/browser/browsing_data/cache_counter.cc

@@ -32,6 +32,8 @@ const char* CacheCounter::GetPrefName() const {

}

void CacheCounter::Count() {

+ // Cancel existing requests.

+ weak_ptr_factory_.InvalidateWeakPtrs();

base::WeakPtr<browsing_data::ConditionalCacheCountingHelper> counter =

browsing_data::ConditionalCacheCountingHelper::CreateForRange(

content::BrowserContext::GetDefaultStoragePartition(profile_),

« no previous file with comments | « no previous file | chrome/browser/browsing_data/media_licenses_counter.cc » ('j') | no next file with comments »