chrome/browser/browsing_data/site_data_counter.cc - Issue 2867033002: Fix BrowsingDataCounter race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/site_data_counter.cc

Issue 2867033002: Fix BrowsingDataCounter race condition (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/site_data_counter.cc

diff --git a/chrome/browser/browsing_data/site_data_counter.cc b/chrome/browser/browsing_data/site_data_counter.cc

index 36397fdae8fcbcb3bfa3b945b6336c6097e6cabc..8106d3ea312c4eef8b0a7371023e5b8f3e574e71 100644

--- a/chrome/browser/browsing_data/site_data_counter.cc

+++ b/chrome/browser/browsing_data/site_data_counter.cc

@@ -20,6 +20,8 @@ const char* SiteDataCounter::GetPrefName() const {

}

void SiteDataCounter::Count() {

+ // Cancel existing requests.

+ weak_ptr_factory_.InvalidateWeakPtrs();

base::Time begin = GetPeriodStart();

auto done_callback =

base::Bind(&SiteDataCounter::Done, weak_ptr_factory_.GetWeakPtr());