components/browsing_data/core/counters/browsing_data_counter.h - Issue 2867033002: Fix BrowsingDataCounter race condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/core/counters/browsing_data_counter.h

Issue 2867033002: Fix BrowsingDataCounter race condition (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browsing_data/core/counters/browsing_data_counter.h

diff --git a/components/browsing_data/core/counters/browsing_data_counter.h b/components/browsing_data/core/counters/browsing_data_counter.h

index d7fbb956dce78eef66fd6c315160d6a2f7b08c23..d7d532ae0346cee91a594c6248d1139a29ba0ab8 100644

--- a/components/browsing_data/core/counters/browsing_data_counter.h

+++ b/components/browsing_data/core/counters/browsing_data_counter.h

@@ -128,7 +128,8 @@ class BrowsingDataCounter {

// Called after the class is initialized by calling |Init|.

virtual void OnInitialized();

- // Count the data.

+ // Count the data. Call ReportResult() when finished. Tasks that are still

+ // running should be cancelled to avoid reporting old results.

virtual void Count() = 0;

// State transition methods.