[Android] Improve sad tab strings

[Android] Improve sad tab strings

Add new header text and more descriptive body text when a tab
has crashed multiple times in a row.

BUG=707352
Review-Url: https://codereview.chromium.org/2866273003
Cr-Commit-Position: refs/heads/master@{#470768}
Committed: https://chromium.googlesource.com/chromium/src/+/91d3ee3c63734399ce574d0ed71f4004fb7e8605

[Theresa, 2017-05-09 20:15:59]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 20:16:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-05-09 21:01:35]

twellington@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Theresa, 2017-05-09 21:01:36]

ptal - screenshots are in the bug

https://codereview.chromium.org/2866273003/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/sad_tab.xml (right):

https://codereview.chromium.org/2866273003/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/sad_tab.xml:28:
android:layout_gravity="center_horizontal"
layout_gravity="center"causes the top of the content to get cut-off in landscape
mode when the content starts scrolling. The combination of center_horizontal and
center works well.

https://codereview.chromium.org/2866273003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
(right):

https://codereview.chromium.org/2866273003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:110:
* @param context Context of the resulting Sad Tab view.
nit: This comment could be better.

[Theresa, 2017-05-09 23:45:08]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 23:46:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:49:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Theresa, 2017-05-10 15:49:35]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 15:50:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-05-10 15:59:46]

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
(right):

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:37:
@IntDef({SAD_TAB_EVENT_DISPLAYED, SAD_TAB_EVENT_BUTTON_CLICKED,
can we generate the enum in java from the c++ side?

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:55:
OnClickListener reloadButtonAction, boolean showSendFeedbackView) {
Seeing that we need to expose the UMA events to be logged in Tab, I wonder if it
would be better to have plain Runnables passed in instead of the
OnClickListeners.  Then this class could be the OnClickListener that just calls
the appropriate runnable, but also logs internally.

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:120:
SpannableString bullet1 =
I would pull out a helper function that takes just the string ID and generates a
bullet.

We might be able to use a SpannableStringBuilder as well after that.

Something like:

new SpannableStringBuilder()
        .append(generateBullet(R.string.sad_tab_reload_close_notabs))
        .append("\n")
        ...

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:168:
// Android cuts off the bullet points. Adjust the x-position so that the bullets
aren't
WAH?!  sadness

[commit-bot: I haz the power, 2017-05-10 18:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:00:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Theresa, 2017-05-10 18:18:20]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 18:19:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-05-10 18:20:22]

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
(right):

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:37:
@IntDef({SAD_TAB_EVENT_DISPLAYED, SAD_TAB_EVENT_BUTTON_CLICKED,
On 2017/05/10 15:59:46, Ted C wrote:
> can we generate the enum in java from the c++ side?

Done.

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:55:
OnClickListener reloadButtonAction, boolean showSendFeedbackView) {
On 2017/05/10 15:59:46, Ted C wrote:
> Seeing that we need to expose the UMA events to be logged in Tab, I wonder if
it
> would be better to have plain Runnables passed in instead of the
> OnClickListeners.  Then this class could be the OnClickListener that just
calls
> the appropriate runnable, but also logs internally.

Done.

https://codereview.chromium.org/2866273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java:120:
SpannableString bullet1 =
On 2017/05/10 15:59:46, Ted C wrote:
> I would pull out a helper function that takes just the string ID and generates
a
> bullet.
> 
> We might be able to use a SpannableStringBuilder as well after that.
> 
> Something like:
> 
> new SpannableStringBuilder()
>         .append(generateBullet(R.string.sad_tab_reload_close_notabs))
>         .append("\n")
>         ...
> 

Done.

[commit-bot: I haz the power, 2017-05-10 19:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:08:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ted C, 2017-05-10 19:15:34]

lgtm

[Theresa, 2017-05-10 19:25:30]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:27:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:46:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Theresa, 2017-05-10 20:50:06]

twellington@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Theresa, 2017-05-10 20:50:07]

+jbudorick@ for chrome/BUILD.gn
+msw@ for sad_tab.cc annotation

[wrong jbudorick, 2017-05-10 20:54:12]

On 2017/05/10 20:50:07, Theresa wrote:
> +jbudorick@ for chrome/BUILD.gn

lgtm

> +msw@ for sad_tab.cc annotation

[jbudorick, 2017-05-10 20:54:44]

On 2017/05/10 20:54:12, wrong jbudorick wrote:
> On 2017/05/10 20:50:07, Theresa wrote:
> > +jbudorick@ for chrome/BUILD.gn
> 
> lgtm

... also lgtm

> 
> > +msw@ for sad_tab.cc annotation

[Theresa, 2017-05-10 23:30:51]

twellington@chromium.org changed reviewers:
+ msw@chromium.org

[Theresa, 2017-05-10 23:30:52]

+msw@ for sad_tab.cc annotation

[msw, 2017-05-10 23:32:32]

https://codereview.chromium.org/2866273003/diff/60001/chrome/browser/ui/sad_t...
File chrome/browser/ui/sad_tab.cc (right):

https://codereview.chromium.org/2866273003/diff/60001/chrome/browser/ui/sad_t...
chrome/browser/ui/sad_tab.cc:39: // A Java counterpart exists in
incomplete sentence

[Theresa, 2017-05-10 23:34:31]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2017-05-10 23:34:33]

https://codereview.chromium.org/2866273003/diff/60001/chrome/browser/ui/sad_t...
File chrome/browser/ui/sad_tab.cc (right):

https://codereview.chromium.org/2866273003/diff/60001/chrome/browser/ui/sad_t...
chrome/browser/ui/sad_tab.cc:39: // A Java counterpart exists in
On 2017/05/10 23:32:32, msw wrote:
> incomplete sentence

Done. Sorry, this line was supposed to be deleted.

[commit-bot: I haz the power, 2017-05-10 23:35:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-10 23:35:54]

sad_tab.cc rubber stamp lgtm

[Theresa, 2017-05-10 23:42:14]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2017-05-10 23:42:14]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-05-10 23:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, jbudorick@chromium.org, jbudorick@google.com
Link to the patchset: https://codereview.chromium.org/2866273003/#ps80001
(title: "Remove extraneous line")

[commit-bot: I haz the power, 2017-05-10 23:43:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 01:17:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494459734954620,
"parent_rev": "b6e728ba97f0d4110d639af798426fd7a516da24", "commit_rev":
"91d3ee3c63734399ce574d0ed71f4004fb7e8605"}

[commit-bot: I haz the power, 2017-05-11 01:17:44]

Description was changed from

==========
[Android] Improve sad tab strings

Add new header text and more descriptive body text when a tab
has crashed multiple times in a row.

BUG=707352
==========

to

==========
[Android] Improve sad tab strings

Add new header text and more descriptive body text when a tab
has crashed multiple times in a row.

BUG=707352

Review-Url: https://codereview.chromium.org/2866273003
Cr-Commit-Position: refs/heads/master@{#470768}
Committed:
https://chromium.googlesource.com/chromium/src/+/91d3ee3c63734399ce574d0ed71f...
==========

[commit-bot: I haz the power, 2017-05-11 01:17:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/91d3ee3c63734399ce574d0ed71f...