Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2866273003: [Android] Improve sad tab strings (Closed)
Patch Set: Remove extraneous line Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/sad_tab.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 <item name="android:layout_width">wrap_content</item> 577 <item name="android:layout_width">wrap_content</item>
578 <item name="android:layout_height">wrap_content</item> 578 <item name="android:layout_height">wrap_content</item>
579 <item name="android:layout_gravity">center_vertical</item> 579 <item name="android:layout_gravity">center_vertical</item>
580 <item name="android:singleLine">true</item> 580 <item name="android:singleLine">true</item>
581 <item name="android:textColor">@android:color/white</item> 581 <item name="android:textColor">@android:color/white</item>
582 <item name="android:textSize">20sp</item> 582 <item name="android:textSize">20sp</item>
583 </style> 583 </style>
584 <style name="BottomSheetContentTitle" parent="TextAppearance.Widget.AppCompa t.Toolbar.Title"> 584 <style name="BottomSheetContentTitle" parent="TextAppearance.Widget.AppCompa t.Toolbar.Title">
585 <item name="android:textSize">20sp</item> 585 <item name="android:textSize">20sp</item>
586 </style> 586 </style>
587 <style name="SadTabBodyText">
588 <item name="android:textColor">@color/sad_tab_body_text_color</item>
589 <item name="android:textSize">14sp</item>
590 <item name="android:layout_gravity">start</item>
591 </style>
587 592
588 <!-- New tab page RecyclerView overscroll color --> 593 <!-- New tab page RecyclerView overscroll color -->
589 <style name="NewTabPageRecyclerView"> 594 <style name="NewTabPageRecyclerView">
590 <item name="android:colorEdgeEffect">@color/google_grey_300</item> 595 <item name="android:colorEdgeEffect">@color/google_grey_300</item>
591 </style> 596 </style>
592 597
593 <!-- History UI --> 598 <!-- History UI -->
594 <style name="HistoryStartIcon"> 599 <style name="HistoryStartIcon">
595 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item> 600 <item name="android:layout_width">@dimen/selectable_list_layout_start_ic on_width</item>
596 <item name="android:layout_height">match_parent</item> 601 <item name="android:layout_height">match_parent</item>
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 <style name="IncognitoNewTabLearnMoreLink"> 718 <style name="IncognitoNewTabLearnMoreLink">
714 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> 719 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
715 <item name="android:clickable">true</item> 720 <item name="android:clickable">true</item>
716 <item name="android:focusable">true</item> 721 <item name="android:focusable">true</item>
717 <item name="android:textSize">14sp</item> 722 <item name="android:textSize">14sp</item>
718 <item name="android:textAllCaps">true</item> 723 <item name="android:textAllCaps">true</item>
719 <item name="android:padding">16dp</item> 724 <item name="android:padding">16dp</item>
720 </style> 725 </style>
721 726
722 </resources> 727 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/sad_tab.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698