Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4969)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java

Issue 2866273003: [Android] Improve sad tab strings (Closed)
Patch Set: Remove extraneous line Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java
index d58a84d342559ca8970fefa7cb32cf7575972bc7..924edc9563babf0cf348c9d0a1ce18d8be577da7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java
@@ -36,22 +36,22 @@ public class SadTabView extends ScrollView {
int width = MeasureSpec.getSize(widthMeasureSpec);
int height = MeasureSpec.getSize(heightMeasureSpec);
- final ButtonCompat mReloadButton = (ButtonCompat) findViewById(R.id.sad_tab_reload_button);
+ final ButtonCompat mButton = (ButtonCompat) findViewById(R.id.sad_tab_button);
- final LinearLayout.LayoutParams mReloadButtonParams =
- (LinearLayout.LayoutParams) mReloadButton.getLayoutParams();
+ final LinearLayout.LayoutParams mButtonParams =
+ (LinearLayout.LayoutParams) mButton.getLayoutParams();
- if ((width > height || width > mThresholdPx) && mReloadButton.getWidth() <= width) {
+ if ((width > height || width > mThresholdPx) && mButton.getWidth() <= width) {
// Orientation is landscape
- mReloadButtonParams.width = LinearLayout.LayoutParams.WRAP_CONTENT;
- mReloadButtonParams.gravity = Gravity.END;
+ mButtonParams.width = LinearLayout.LayoutParams.WRAP_CONTENT;
+ mButtonParams.gravity = Gravity.END;
} else {
// Orientation is portrait
- mReloadButtonParams.width = LinearLayout.LayoutParams.MATCH_PARENT;
- mReloadButtonParams.gravity = Gravity.FILL_HORIZONTAL;
+ mButtonParams.width = LinearLayout.LayoutParams.MATCH_PARENT;
+ mButtonParams.gravity = Gravity.FILL_HORIZONTAL;
}
- mReloadButton.setLayoutParams(mReloadButtonParams);
+ mButton.setLayoutParams(mButtonParams);
super.onMeasure(widthMeasureSpec, heightMeasureSpec);
}
}

Powered by Google App Engine
This is Rietveld 408576698