[Android] Improve sad tab strings

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.Application;
 import android.content.Context;
 import android.content.Intent;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.Rect;
 import android.net.Uri;
 import android.os.Bundle;
 import android.provider.Browser;
 import android.support.annotation.Nullable;
 import android.support.v4.view.ViewCompat;
 import android.text.TextUtils;
 import android.util.Log;
 import android.view.ContextThemeWrapper;
 import android.view.View;
-import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.view.accessibility.AccessibilityEvent;
 import android.widget.FrameLayout;
 import android.widget.FrameLayout.LayoutParams;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.ObserverList;
 import org.chromium.base.ObserverList.RewindableIterator;
@@ skipping 1652 matching lines @@
         if (getInterceptNavigationDelegate() != null) {
             getInterceptNavigationDelegate().maybeUpdateNavigationHistory();
         }
     }
 
     /**
      * Constructs and shows a sad tab (Aw, Snap!).
      */
     protected void showSadTab() {
         if (getContentViewCore() != null) {
-            OnClickListener suggestionAction = new OnClickListener() {
+            // If the tab has crashed twice in a row change the sad tab view to the "Send Feedback"
+            // version and change the onClickListener.
+            final boolean showSendFeedbackView = mSadTabSuccessiveRefreshCounter >= 1;
+
+            Runnable suggestionAction = new Runnable() {
                 @Override
-                public void onClick(View view) {
+                public void run() {
                     Activity activity = mWindowAndroid.getActivity().get();
                     assert activity != null;
                     HelpAndFeedback.getInstance(activity).show(activity,
                             activity.getString(R.string.help_context_sad_tab),
                             Profile.getLastUsedProfile(), null);
                 }
             };
 
-            // If the tab has crashed twice in a row change the button to "Send Feedback" and
-            // change the onClickListener.
-            final boolean showSendFeedbackButton = mSadTabSuccessiveRefreshCounter >= 1;
-            OnClickListener buttonAction = new OnClickListener() {
-
+            Runnable buttonAction = new Runnable() {
                 @Override
-                public void onClick(View v) {
-                    if (showSendFeedbackButton) {
+                public void run() {
+                    if (showSendFeedbackView) {
                         getActivity().startHelpAndFeedback(Tab.this, "MobileSadTabFeedback");
                     } else {
                         reload();
                     }
                 }
             };
 
             // Make sure we are not adding the "Aw, snap" view over an existing one.
             assert mSadTabView == null;
 
             mSadTabView = SadTabViewFactory.createSadTabView(mThemedApplicationContext,
-                    suggestionAction, buttonAction, showSendFeedbackButton
-                            ? R.string.sad_tab_send_feedback_label : R.string.sad_tab_reload_label);
+                    suggestionAction, buttonAction, showSendFeedbackView);
             mSadTabSuccessiveRefreshCounter++;
             // Show the sad tab inside ContentView.
             getContentViewCore().getContainerView().addView(
                     mSadTabView, new FrameLayout.LayoutParams(
                             LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));
             notifyContentChanged();
         }
         FullscreenManager fullscreenManager = getFullscreenManager();
         if (fullscreenManager != null) {
             fullscreenManager.setPositionsForTabToNonFullscreen();
@@ skipping 1331 matching lines @@
     private native void nativeLoadOriginalImage(long nativeTabAndroid);
     private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
     private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
             InterceptNavigationDelegate delegate);
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
     private native void nativeSetWebappManifestScope(long nativeTabAndroid, String scope);
     private native void nativeEnableEmbeddedMediaExperience(long nativeTabAndroid, boolean enabled);
 }