MD Bookmarks: Add commands for 'Open in <x>' menu items

MD Bookmarks: Add commands for 'Open in <x>' menu items

This adds 'Open in new tab', 'Open in new window' and 'Open in incognito
window' to the context menu in MD Bookmarks, along with keyboard
shortcuts for the first two commands.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864993002
Cr-Commit-Position: refs/heads/master@{#471646}
Committed: https://chromium.googlesource.com/chromium/src/+/13a46646f69af7604810223dc4be9903d5644873

[tsergeant, 2017-05-08 04:00:24]

Description was changed from

==========
MD Bookmarks: Add commands for 'Open in <x>' menu items

This adds 'Open in new tab', 'Open in new window' and 'Open in incognito
window' to the context menu in MD Bookmarks, along with keyboard
shortcuts for the first two commands.

BUG=692837
==========

to

==========
MD Bookmarks: Add commands for 'Open in <x>' menu items

This adds 'Open in new tab', 'Open in new window' and 'Open in incognito
window' to the context menu in MD Bookmarks, along with keyboard
shortcuts for the first two commands.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-09 04:22:33]

Patchset #1 (id:1) has been deleted

[tsergeant, 2017-05-09 04:25:18]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-05-09 04:25:23]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 04:26:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 06:24:10]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-05-12 03:22:52]

https://codereview.chromium.org/2864993002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2864993002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:223: * Note that these
will be ordered by insertion order into the |itemIds| set.
Mention that this assumes itemIds are all at the same depth.

https://codereview.chromium.org/2864993002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/command_manager_test.js (right):

https://codereview.chromium.org/2864993002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/command_manager_test.js:183:
assertFalse(commandItem[Command.OPEN_INCOGNITO].hidden);
Why is OPEN_NEW_WINDOW not included here?

[tsergeant, 2017-05-12 05:15:27]

https://codereview.chromium.org/2864993002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2864993002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:223: * Note that these
will be ordered by insertion order into the |itemIds| set.
On 2017/05/12 03:22:52, calamity wrote:
> Mention that this assumes itemIds are all at the same depth.

As discussed, it doesn't assume that, but I've expanded the comment to clarify.

https://codereview.chromium.org/2864993002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/command_manager_test.js (right):

https://codereview.chromium.org/2864993002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/command_manager_test.js:183:
assertFalse(commandItem[Command.OPEN_INCOGNITO].hidden);
On 2017/05/12 03:22:52, calamity wrote:
> Why is OPEN_NEW_WINDOW not included here?

Laziness, mostly. I don't really expect it to diverge from the others, but I've
added it in case.

[tsergeant, 2017-05-12 05:15:32]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 05:15:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-05-12 06:11:07]

lgtm

[commit-bot: I haz the power, 2017-05-12 06:21:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:21:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-05-12 06:24:22]

tsergeant@chromium.org changed reviewers:
+ reillyg@chromium.org

[tsergeant, 2017-05-12 06:24:23]

+reillyg@ for _api_features.json. PTAL, thanks

[Reilly Grant (use Gerrit), 2017-05-12 15:33:48]

lgtm

[tsergeant, 2017-05-14 22:53:58]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-14 22:54:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-14 23:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-14 23:53:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tsergeant, 2017-05-14 23:56:25]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-14 23:56:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 01:21:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494806185080870,
"parent_rev": "d379a172ffe86d179a10a6207855004b0d781650", "commit_rev":
"13a46646f69af7604810223dc4be9903d5644873"}

[commit-bot: I haz the power, 2017-05-15 01:21:26]

Description was changed from

==========
MD Bookmarks: Add commands for 'Open in <x>' menu items

This adds 'Open in new tab', 'Open in new window' and 'Open in incognito
window' to the context menu in MD Bookmarks, along with keyboard
shortcuts for the first two commands.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Add commands for 'Open in <x>' menu items

This adds 'Open in new tab', 'Open in new window' and 'Open in incognito
window' to the context menu in MD Bookmarks, along with keyboard
shortcuts for the first two commands.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864993002
Cr-Commit-Position: refs/heads/master@{#471646}
Committed:
https://chromium.googlesource.com/chromium/src/+/13a46646f69af7604810223dc4be...
==========

[commit-bot: I haz the power, 2017-05-15 01:21:26]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/13a46646f69af7604810223dc4be...