Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868383004:
MD Bookmarks: Make CommandManager available as a singleton (Closed)
DescriptionMD Bookmarks: Make CommandManager available as a singleton
This makes the command manager globally available, which is necessary
to allow <bookmark-item>s to execute commands.
This CL is split apart from other changes as the diff from reformatting
the entire file is very large.
BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2868383004
Cr-Commit-Position: refs/heads/master@{#471651}
Committed: https://chromium.googlesource.com/chromium/src/+/2db36268c223640a0ed5cfb98de3ca949a8a9b94
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase? #
Depends on Patchset: Messages
Total messages: 22 (14 generated)
Description was changed from ========== MD Bookmarks: Make CommandManager available as a singleton This makes the command manager globally available, which is necessary to allow <bookmark-item>s to execute commands. This CL is split apart from other changes as the diff from reformatting the entire file is very large. BUG=692837 ========== to ========== MD Bookmarks: Make CommandManager available as a singleton This makes the command manager globally available, which is necessary to allow <bookmark-item>s to execute commands. This CL is split apart from other changes as the diff from reformatting the entire file is very large. BUG=692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tsergeant@chromium.org changed reviewers: + calamity@chromium.org
https://codereview.chromium.org/2868383004/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_bookmarks/command_manager.js (right): https://codereview.chromium.org/2868383004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_bookmarks/command_manager.js:41: CommandManager.instance_ = this; The only changes are here in attached(), below in detached(), and at the end of the file. Everything else is just the result of clang-format.
lgtm https://codereview.chromium.org/2868383004/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_bookmarks/command_manager.js (right): https://codereview.chromium.org/2868383004/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_bookmarks/command_manager.js:41: CommandManager.instance_ = this; On 2017/05/11 05:02:24, tsergeant wrote: > The only changes are here in attached(), below in detached(), and at the end of > the file. Everything else is just the result of clang-format. Acknowledged.
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tsergeant@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from calamity@chromium.org Link to the patchset: https://codereview.chromium.org/2868383004/#ps20001 (title: "Rebase?")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494812747620060,
"parent_rev": "b93c6677d020067d9dfcf31c8b79f8a5a66e69ce", "commit_rev":
"2db36268c223640a0ed5cfb98de3ca949a8a9b94"}
Message was sent while issue was closed.
Description was changed from ========== MD Bookmarks: Make CommandManager available as a singleton This makes the command manager globally available, which is necessary to allow <bookmark-item>s to execute commands. This CL is split apart from other changes as the diff from reformatting the entire file is very large. BUG=692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Bookmarks: Make CommandManager available as a singleton This makes the command manager globally available, which is necessary to allow <bookmark-item>s to execute commands. This CL is split apart from other changes as the diff from reformatting the entire file is very large. BUG=692837 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2868383004 Cr-Commit-Position: refs/heads/master@{#471651} Committed: https://chromium.googlesource.com/chromium/src/+/2db36268c223640a0ed5cfb98de3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2db36268c223640a0ed5cfb98de3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
