Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Issue 2864993002: MD Bookmarks: Add commands for 'Open in <x>' menu items (Closed)
Patch Set: Review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h" 5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 AddLocalizedString(source, "menuAddBookmark", 54 AddLocalizedString(source, "menuAddBookmark",
55 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_BOOKMARK); 55 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_BOOKMARK);
56 AddLocalizedString(source, "menuAddFolder", 56 AddLocalizedString(source, "menuAddFolder",
57 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_FOLDER); 57 IDS_MD_BOOKMARK_MANAGER_MENU_ADD_FOLDER);
58 AddLocalizedString(source, "menuCopyURL", 58 AddLocalizedString(source, "menuCopyURL",
59 IDS_MD_BOOKMARK_MANAGER_MENU_COPY_URL); 59 IDS_MD_BOOKMARK_MANAGER_MENU_COPY_URL);
60 AddLocalizedString(source, "menuDelete", IDS_DELETE); 60 AddLocalizedString(source, "menuDelete", IDS_DELETE);
61 AddLocalizedString(source, "menuEdit", IDS_EDIT); 61 AddLocalizedString(source, "menuEdit", IDS_EDIT);
62 AddLocalizedString(source, "menuExport", IDS_MD_BOOKMARK_MANAGER_MENU_EXPORT); 62 AddLocalizedString(source, "menuExport", IDS_MD_BOOKMARK_MANAGER_MENU_EXPORT);
63 AddLocalizedString(source, "menuImport", IDS_MD_BOOKMARK_MANAGER_MENU_IMPORT); 63 AddLocalizedString(source, "menuImport", IDS_MD_BOOKMARK_MANAGER_MENU_IMPORT);
64 // TODO(tsergeant): These are not the exact strings specified by UI. Reconcile
65 // the differences between these strings and the work in crbug.com/708815.
66 AddLocalizedString(source, "menuOpenAllNewTab", IDS_BOOKMARK_BAR_OPEN_ALL);
67 AddLocalizedString(source, "menuOpenAllNewWindow",
68 IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW);
69 AddLocalizedString(source, "menuOpenAllIncognito",
70 IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO);
71 AddLocalizedString(source, "menuOpenNewTab",
72 IDS_BOOKMARK_BAR_OPEN_IN_NEW_TAB);
73 AddLocalizedString(source, "menuOpenNewWindow",
74 IDS_BOOKMARK_BAR_OPEN_IN_NEW_WINDOW);
75 AddLocalizedString(source, "menuOpenIncognito",
76 IDS_BOOKMARK_BAR_OPEN_INCOGNITO);
64 AddLocalizedString(source, "menuRename", IDS_MD_BOOKMARK_MANAGER_MENU_RENAME); 77 AddLocalizedString(source, "menuRename", IDS_MD_BOOKMARK_MANAGER_MENU_RENAME);
65 AddLocalizedString(source, "menuSort", IDS_MD_BOOKMARK_MANAGER_MENU_SORT); 78 AddLocalizedString(source, "menuSort", IDS_MD_BOOKMARK_MANAGER_MENU_SORT);
66 AddLocalizedString(source, "noSearchResults", 79 AddLocalizedString(source, "noSearchResults",
67 IDS_MD_BOOKMARK_MANAGER_NO_SEARCH_RESULTS); 80 IDS_MD_BOOKMARK_MANAGER_NO_SEARCH_RESULTS);
68 AddLocalizedString(source, "renameFolderTitle", 81 AddLocalizedString(source, "renameFolderTitle",
69 IDS_MD_BOOKMARK_MANAGER_FOLDER_RENAME_TITLE); 82 IDS_MD_BOOKMARK_MANAGER_FOLDER_RENAME_TITLE);
70 AddLocalizedString(source, "searchPrompt", 83 AddLocalizedString(source, "searchPrompt",
71 IDS_BOOKMARK_MANAGER_SEARCH_BUTTON); 84 IDS_BOOKMARK_MANAGER_SEARCH_BUTTON);
72 AddLocalizedString(source, "saveEdit", IDS_SAVE); 85 AddLocalizedString(source, "saveEdit", IDS_SAVE);
73 AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE); 86 AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE);
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // Set up the chrome://bookmarks/ source. 143 // Set up the chrome://bookmarks/ source.
131 Profile* profile = Profile::FromWebUI(web_ui); 144 Profile* profile = Profile::FromWebUI(web_ui);
132 content::WebUIDataSource::Add(profile, 145 content::WebUIDataSource::Add(profile,
133 CreateMdBookmarksUIHTMLSource(profile)); 146 CreateMdBookmarksUIHTMLSource(profile));
134 } 147 }
135 148
136 // static 149 // static
137 bool MdBookmarksUI::IsEnabled() { 150 bool MdBookmarksUI::IsEnabled() {
138 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks); 151 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks);
139 } 152 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_bookmarks/constants.js ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698