Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Issue 2864993002: MD Bookmarks: Add commands for 'Open in <x>' menu items (Closed)
Patch Set: Review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/constants.js ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
diff --git a/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc b/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
index 6dc90f2e8692f84344b09623cdfb137201d6c783..521277b8b1a7732fa9a0cd769430b2d6ee158e95 100644
--- a/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
+++ b/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
@@ -61,6 +61,19 @@ content::WebUIDataSource* CreateMdBookmarksUIHTMLSource(Profile* profile) {
AddLocalizedString(source, "menuEdit", IDS_EDIT);
AddLocalizedString(source, "menuExport", IDS_MD_BOOKMARK_MANAGER_MENU_EXPORT);
AddLocalizedString(source, "menuImport", IDS_MD_BOOKMARK_MANAGER_MENU_IMPORT);
+ // TODO(tsergeant): These are not the exact strings specified by UI. Reconcile
+ // the differences between these strings and the work in crbug.com/708815.
+ AddLocalizedString(source, "menuOpenAllNewTab", IDS_BOOKMARK_BAR_OPEN_ALL);
+ AddLocalizedString(source, "menuOpenAllNewWindow",
+ IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW);
+ AddLocalizedString(source, "menuOpenAllIncognito",
+ IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO);
+ AddLocalizedString(source, "menuOpenNewTab",
+ IDS_BOOKMARK_BAR_OPEN_IN_NEW_TAB);
+ AddLocalizedString(source, "menuOpenNewWindow",
+ IDS_BOOKMARK_BAR_OPEN_IN_NEW_WINDOW);
+ AddLocalizedString(source, "menuOpenIncognito",
+ IDS_BOOKMARK_BAR_OPEN_INCOGNITO);
AddLocalizedString(source, "menuRename", IDS_MD_BOOKMARK_MANAGER_MENU_RENAME);
AddLocalizedString(source, "menuSort", IDS_MD_BOOKMARK_MANAGER_MENU_SORT);
AddLocalizedString(source, "noSearchResults",
« no previous file with comments | « chrome/browser/resources/md_bookmarks/constants.js ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698