Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2864753002: Mojo code generator: simplify how imported types and values are handled. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo code generator: simplify how imported types and values are handled. With this change, there is no need to make deep-copies of types and values from the imported module. Besides, Module.imports are a list of Modules, instead of dictionary objects with redundant information. This CL also removes some trivial IsXXXField forwarding functions in mojom_js_generator.py BUG=718614 Review-Url: https://codereview.chromium.org/2864753002 Cr-Commit-Position: refs/heads/master@{#470054} Committed: https://chromium.googlesource.com/chromium/src/+/8899feb0588fd6fa12ecd3e5807cf55aa778eac7

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -441 lines) Patch
M mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl View 1 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl View 1 3 chunks +12 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 10 chunks +61 lines, -63 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 6 chunks +234 lines, -289 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 13 chunks +16 lines, -36 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/translate.py View 1 chunk +3 lines, -25 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-05 21:56:11 UTC) #7
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-08 15:18:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864753002/20001
3 years, 7 months ago (2017-05-08 16:17:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/209678)
3 years, 7 months ago (2017-05-08 16:43:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864753002/20001
3 years, 7 months ago (2017-05-08 18:03:15 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:18:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8899feb0588fd6fa12ecd3e5807c...

Powered by Google App Engine
This is Rietveld 408576698