Mojo code generator: change where to add computed data to mojom definitions

Mojo code generator: change where to add computed data to mojom definitions

So that the same work is not done multiple times.

BUG=718614
Review-Url: https://codereview.chromium.org/2863353002
Cr-Commit-Position: refs/heads/master@{#470986}
Committed: https://chromium.googlesource.com/chromium/src/+/121205ac1fd5cf2274a6f429dec741fb602f7081

[yzshen1, 2017-05-07 08:23:23]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 08:23:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-05-07 08:25:18]

Description was changed from

==========
Mojo code generator: introduce stylizer to define naming style for target
languages.

This CL also changes where to add computed data to mojom definitions, so that
the same work is not done multiple times.


This CL doesn't add customized stylizer for any target language. That will be
done in follow-up CLs.

BUG=718614
==========

to

==========
Mojo code generator: change where to add computed data to mojom definitions

So that the same work is not done multiple times.

BUG=718614
==========

[yzshen1, 2017-05-07 08:25:18]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2017-05-07 08:25:38]

Hi, Ken.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2017-05-07 08:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 08:45:04]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2017-05-08 15:32:07]

LGTM but it seems something is definitely wrong with the JS bindings, given the
red bots. I can't see anything obvious in this patch or the last one though.

[yzshen1, 2017-05-08 16:31:48]

On 2017/05/08 15:32:07, Ken Rockot wrote:
> LGTM but it seems something is definitely wrong with the JS bindings, given
the
> red bots. I can't see anything obvious in this patch or the last one though.

Thanks! I will look into it and update the CL.

[yzshen1, 2017-05-11 15:38:16]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-05-11 15:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2863353002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-05-11 15:38:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-05-11 15:47:32]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2017-05-11 16:11:29]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-05-11 16:11:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2863353002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-05-11 16:11:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:12:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494519089463460,
"parent_rev": "c96bfeee5db953d0c7a5e2d636f2622323b61f4f", "commit_rev":
"ab9fc9f7025e32fb205725c76436a93beeabaadb"}

[commit-bot: I haz the power, 2017-05-11 17:12:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494519089463460,
"parent_rev": "d997518a95d124b2deebb67e37c96cff7fe5c1c2", "commit_rev":
"121205ac1fd5cf2274a6f429dec741fb602f7081"}

[commit-bot: I haz the power, 2017-05-11 17:12:45]

Description was changed from

==========
Mojo code generator: change where to add computed data to mojom definitions

So that the same work is not done multiple times.

BUG=718614
==========

to

==========
Mojo code generator: change where to add computed data to mojom definitions

So that the same work is not done multiple times.

BUG=718614

Review-Url: https://codereview.chromium.org/2863353002
Cr-Commit-Position: refs/heads/master@{#470986}
Committed:
https://chromium.googlesource.com/chromium/src/+/121205ac1fd5cf2274a6f429dec7...
==========

[commit-bot: I haz the power, 2017-05-11 17:12:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/121205ac1fd5cf2274a6f429dec7...