mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl - Issue 2864753002: Mojo code generator: simplify how imported types and values are handled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl

Issue 2864753002: Mojo code generator: simplify how imported types and values are handled. (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl ('k') | mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl b/mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl

index 4823febeca9f20b1ffcfe685962e12ab8f28a570..dde69aeffdaab9344bfd8bc937208680e30462ca 100644

--- a/mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/js_templates/union_definition.tmpl

@@ -89,7 +89,7 @@ Object.defineProperty({{union.name}}.prototype, "{{field.name}}", {

switch (val.$tag) {

{%- for field in union.fields %}

case {{union.name}}.Tags.{{field.name}}:

-{%- if field|is_bool_field %}

+{%- if field.kind|is_bool_kind %}

encoder.writeUint8(val.{{field.name}} ? 1 : 0);

{%- else %}

encoder.{{field.kind|union_encode_snippet}}val.{{field.name}});

@@ -115,7 +115,7 @@ Object.defineProperty({{union.name}}.prototype, "{{field.name}}", {

switch (tag) {

{%- for field in union.fields %}

case {{union.name}}.Tags.{{field.name}}:

-{%- if field|is_bool_field %}

+{%- if field.kind|is_bool_kind %}

result.{{field.name}} = decoder.readUint8() ? true : false;

{%- else %}

result.{{field.name}} = decoder.{{field.kind|union_decode_snippet}};