Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2864543002: Mojo code generator: makes the filters member methods of generator if necessary. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo code generator: makes the filters member methods of generator if necessary. So that we don't need to use global variables. BUG=718614 Review-Url: https://codereview.chromium.org/2864543002 Cr-Commit-Position: refs/heads/master@{#469530} Committed: https://chromium.googlesource.com/chromium/src/+/f554fc255c471ecba312cc67747f8badf95a7724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -559 lines) Patch
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 13 chunks +442 lines, -452 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 3 chunks +56 lines, -59 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 3 chunks +46 lines, -48 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? This CL just simply moves things around. ...
3 years, 7 months ago (2017-05-04 22:13:38 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-04 23:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864543002/1
3 years, 7 months ago (2017-05-04 23:54:43 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:04:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f554fc255c471ecba312cc67747f...

Powered by Google App Engine
This is Rietveld 408576698