Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2864243003:
[DMC #5.8] Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place (Closed)
DescriptionMove SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place
This method was moved from DocumentMarkerListEditor to SpellCheckMarkerListImpl
in https://codereview.chromium.org/2871823002, but the was left in
DocumentMarkerListEditor.cpp to make that CL smaller. This CL moves this method
to its final place in SpellCheckMarkerListImpl.cpp.
BUG=707867
Review-Url: https://codereview.chromium.org/2864243003
Cr-Commit-Position: refs/heads/master@{#472692}
Committed: https://chromium.googlesource.com/chromium/src/+/8a7b21235feafd7a1c7364df445ea523443882af
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Total comments: 1
Patch Set 4 : Remove blank line #
Dependent Patchsets: Messages
Total messages: 26 (18 generated)
Description was changed from ========== Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl from DocumentMarkerListEditor.cpp to SpellCheckMarkerListImpl.cpp. This method was moved from DocumentMarkerListEditor to SpellCheckMarkerListImpl in https://codereview.chromium.org/2871823002, but the was left in DocumentMarkerListEditor.cpp to make that CL smaller. This CL moves this method to its final place in SpellCheckMarkerListImpl.cpp. BUG=707867 ========== to ========== Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place This method was moved from DocumentMarkerListEditor to SpellCheckMarkerListImpl in https://codereview.chromium.org/2871823002, but the was left in DocumentMarkerListEditor.cpp to make that CL smaller. This CL moves this method to its final place in SpellCheckMarkerListImpl.cpp. BUG=707867 ==========
rlanday@chromium.org changed reviewers: + xiaochengh@chromium.org, yosin@chromium.org
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
lgtm w/ small nit https://codereview.chromium.org/2864243003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp (right): https://codereview.chromium.org/2864243003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp:94: nit: could you remove an extra blank line?
The CQ bit was checked by rlanday@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2864243003/#ps60001 (title: "Remove blank line")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rlanday@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rlanday@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495070928034990,
"parent_rev": "60b43f716972ded8acc86db0ac60fb524f061bf9", "commit_rev":
"8a7b21235feafd7a1c7364df445ea523443882af"}
Message was sent while issue was closed.
Description was changed from ========== Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place This method was moved from DocumentMarkerListEditor to SpellCheckMarkerListImpl in https://codereview.chromium.org/2871823002, but the was left in DocumentMarkerListEditor.cpp to make that CL smaller. This CL moves this method to its final place in SpellCheckMarkerListImpl.cpp. BUG=707867 ========== to ========== Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place This method was moved from DocumentMarkerListEditor to SpellCheckMarkerListImpl in https://codereview.chromium.org/2871823002, but the was left in DocumentMarkerListEditor.cpp to make that CL smaller. This CL moves this method to its final place in SpellCheckMarkerListImpl.cpp. BUG=707867 Review-Url: https://codereview.chromium.org/2864243003 Cr-Commit-Position: refs/heads/master@{#472692} Committed: https://chromium.googlesource.com/chromium/src/+/8a7b21235feafd7a1c7364df445e... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/8a7b21235feafd7a1c7364df445e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
